You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/01 08:00:25 UTC

[GitHub] [flink] pnowojski commented on a change in pull request #17081: [FLINK-23797][tests] Wait for all task running before savepoint for a…

pnowojski commented on a change in pull request #17081:
URL: https://github.com/apache/flink/pull/17081#discussion_r699975418



##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java
##########
@@ -206,6 +206,7 @@ private void testStopWithSavepointForFlip27Source(boolean drain) throws Exceptio
             client.submitJob(jobGraph).get();
 
             BoundedPassThroughOperator.getProgressLatch().await();
+            waitForAllTaskRunning(cluster.getMiniCluster(), jobId, false);

Review comment:
       Here and in other places:
   1. Shouldn't the latch above be enough? Why do we need to additionally wait for all tasks running?
   2. If we need `waitForAllTaskRunning()`, do we still need the latch?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org