You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/01/10 01:45:49 UTC

[Apache Bloodhound] #348: Wrong alignment of reporter, opened, type and status fields

#348: Wrong alignment of reporter, opened, type and status fields
-----------------------+-----------------------
 Reporter:  gjm        |      Owner:  nobody
     Type:  defect     |     Status:  new
 Priority:  minor      |  Milestone:  Release 4
Component:  dashboard  |    Version:
 Keywords:             |
-----------------------+-----------------------
 It appears that although we corrected some of the alignment of fields in
 #242 there were other fields that continue to look odd (or have become odd
 since.)

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/348>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #348: Wrong alignment of reporter, opened, type and status fields

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#348: Wrong alignment of reporter, opened, type and status fields
------------------------+-----------------------
  Reporter:  gjm        |      Owner:  nobody
      Type:  defect     |     Status:  new
  Priority:  minor      |  Milestone:  Release 4
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+-----------------------

Comment (by gjm):

 I couldn't resist a quick look at the issue.. Given the fix from #242, I
 think something like the following should work:

 {{{
 #!diff
 Index: bloodhound_theme/bhtheme/templates/bh_ticket.html
 ===================================================================
 --- bloodhound_theme/bhtheme/templates/bh_ticket.html   (revision 1431144)
 +++ bloodhound_theme/bhtheme/templates/bh_ticket.html   (working copy)
 @@ -310,7 +310,7 @@
                  setup_sticky_panel('#overview');
                </script>

 -              <div>
 +              <div id="basic-properties">
                  <div class="row">
                    <div class="span4">
                      <div class="row">
 Index: bloodhound_theme/bhtheme/htdocs/bloodhound.css
 ===================================================================
 --- bloodhound_theme/bhtheme/htdocs/bloodhound.css      (revision 1430903)
 +++ bloodhound_theme/bhtheme/htdocs/bloodhound.css      (working copy)
 @@ -218,7 +218,7 @@
    padding-left: 5px;
  }

 -.ticket .properties .enum h5 {
 +.ticket .properties .enum h5, #basic-properties h5 {
    margin-top: 0px;
  }

 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/348#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #348: Wrong alignment of reporter, opened, type and status fields

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#348: Wrong alignment of reporter, opened, type and status fields
------------------------+-----------------------
  Reporter:  gjm        |      Owner:  gjm
      Type:  defect     |     Status:  closed
  Priority:  minor      |  Milestone:  Release 4
 Component:  dashboard  |    Version:
Resolution:  fixed      |   Keywords:
------------------------+-----------------------
Changes (by gjm):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 r1431296 fixes with above diff

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/348#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #348: Wrong alignment of reporter, opened, type and status fields

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#348: Wrong alignment of reporter, opened, type and status fields
------------------------+-----------------------
  Reporter:  gjm        |      Owner:  nobody
      Type:  defect     |     Status:  new
  Priority:  minor      |  Milestone:  Release 4
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+-----------------------

Comment (by olemis):

 +1 . This issue has been introduced after applying
 [attachment:t146_r1418195_ticket_header.diff:ticket:146 this patch]
 submitted for #146 ([comment:41:ticket:146 afaics] in r1427698 ).

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/348#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #348: Wrong alignment of reporter, opened, type and status fields

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#348: Wrong alignment of reporter, opened, type and status fields
------------------------+-----------------------
  Reporter:  gjm        |      Owner:  gjm
      Type:  defect     |     Status:  assigned
  Priority:  minor      |  Milestone:  Release 4
 Component:  dashboard  |    Version:
Resolution:             |   Keywords:
------------------------+-----------------------
Changes (by olemis):

 * owner:  nobody => gjm
 * status:  new => assigned


Comment:

 @gjm : you're almost there hence I'm assigning this ticket to you . Hope
 you don't mind .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/348#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker