You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by trystanleftwich <gi...@git.apache.org> on 2015/10/11 05:40:24 UTC
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
GitHub user trystanleftwich opened a pull request:
https://github.com/apache/spark/pull/9065
[SPARK-11052] Spaces in the build dir causes failures in the build/mv…
…n script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trystanleftwich/spark SPARK-11052
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9065
----
commit 76dcd506c03441f15ee81128e555dcebf74ea58d
Author: trystanleftwich <tr...@atscale.com>
Date: 2015-10-11T03:37:03Z
[SPARK-11052] Spaces in the build dir causes failures in the build/mvn script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9065#issuecomment-147475702
[Test build #1876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1876/console) for PR 9065 at commit [`76dcd50`](https://github.com/apache/spark/commit/76dcd506c03441f15ee81128e555dcebf74ea58d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9065#discussion_r41707246
--- Diff: make-distribution.sh ---
@@ -121,7 +121,7 @@ if [ $(command -v git) ]; then
fi
-if [ ! $(command -v "$MVN") ] ; then
+if [ ! "$(command -v "$MVN")" ] ; then
--- End diff --
Just making sure this works as expected with quotes within quotes? Otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9065
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9065#issuecomment-147151382
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by trystanleftwich <gi...@git.apache.org>.
Github user trystanleftwich commented on a diff in the pull request:
https://github.com/apache/spark/pull/9065#discussion_r41761657
--- Diff: make-distribution.sh ---
@@ -121,7 +121,7 @@ if [ $(command -v git) ]; then
fi
-if [ ! $(command -v "$MVN") ] ; then
+if [ ! "$(command -v "$MVN")" ] ; then
--- End diff --
It does, here is the output from that line when it has quotes:
+ '[' '!' '/tmp/test spaces/spark/build/mvn' ']'
Before:
+ '[' '!' /tmp/test spaces/spark/build/mvn ']'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9065#issuecomment-147440268
[Test build #1876 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1876/consoleFull) for PR 9065 at commit [`76dcd50`](https://github.com/apache/spark/commit/76dcd506c03441f15ee81128e555dcebf74ea58d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9065#discussion_r41768863
--- Diff: make-distribution.sh ---
@@ -121,7 +121,7 @@ if [ $(command -v git) ]; then
fi
-if [ ! $(command -v "$MVN") ] ; then
+if [ ! "$(command -v "$MVN")" ] ; then
--- End diff --
Yeah I tried it locally too. Just making sure the first two double qutoes didn't somehow bind more closely than the parens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11052] Spaces in the build dir causes f...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9065#issuecomment-147161376
This looks reasonable to me. It reminds me: it would be nice to run http://www.shellcheck.net/ on these scripts, since that tool can find more of these types of quoting errors. Even cooler would be integrating it into our build as a linter!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org