(orc) branch main updated: ORC-1940: Add threads dependency to orc lib in Meson

[do...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 15d86dfca ORC-1940: Add threads dependency to orc lib in Meson
15d86dfca is described below

commit 15d86dfcad6fc80ee24cf785419a820a55db103b
Author: Will Ayd <wi...@icloud.com>
AuthorDate: Wed Jun 25 09:37:12 2025 -0700

    ORC-1940: Add threads dependency to orc lib in Meson
    
    ### What changes were proposed in this pull request?
    
    This explicitly adds the threads dependency to the orc library when built in the Meson configuration
    
    ### Why are the changes needed?
    
    In the current CI, no failure is reported because the threads dependency is transitively provided by the protobuf dependency, when protobuf is included from source. However, some older protobuf libraries do not correctly specify in their pkg-config files that threads is a transitive dependency, so if built on a system where an older protobuf version exists orc will fail to build. This is exactly the case in the Apache Arrow CI, which you can see https://github.com/apache/arrow/actions [...]
    
    ### How was this patch tested?
    
    Compiled and tested locally
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No
    
    Closes #2301 from WillAyd/add-threads-dep.
    
    Authored-by: Will Ayd <wi...@icloud.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 c++/src/meson.build | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/c++/src/meson.build b/c++/src/meson.build
index d170e0163..3d77d3242 100644
--- a/c++/src/meson.build
+++ b/c++/src/meson.build
@@ -173,6 +173,8 @@ source_files += files(
 
 incdir = include_directories('../include')
 orc_format_proto_dep = dependency('orc_format_proto')
+# zstd requires us to add the threads
+threads_dep = dependency('threads')
 
 orc_lib = library(
     'orc',
@@ -184,6 +186,7 @@ orc_lib = library(
         snappy_dep,
         lz4_dep,
         zstd_dep,
+        threads_dep,
     ],
     include_directories: incdir,
     install: true,