You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/11 17:34:06 UTC
Review Request 67516: Added a resource utility `isScalarQuantity`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67516/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
`isScalarQuantity()` checks if a `Resources` object
is "pure" scalar quantity i.e. its `Resource`(s) only has
name, type (set to scalar) and scalar fields set.
Also added tests.
Diffs
-----
include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
Diff: https://reviews.apache.org/r/67516/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67516: Added a resource utility `isScalarQuantity`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67516/#review204555
-----------------------------------------------------------
PASS: Mesos patch 67516 was successfully built and tested.
Reviews applied: `['67510', '67516']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67516
- Mesos Reviewbot Windows
On June 11, 2018, 5:34 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67516/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 5:34 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `isScalarQuantity()` checks if a `Resources` object
> is "pure" scalar quantity i.e. its `Resource`(s) only has
> name, type (set to scalar) and scalar fields set.
>
> Also added tests.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
> include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
> src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
> src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
> src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
>
>
> Diff: https://reviews.apache.org/r/67516/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67516: Added a resource utility `isScalarQuantity`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67516/
-----------------------------------------------------------
(Updated June 19, 2018, 2:30 p.m.)
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
`isScalarQuantity()` checks if a `Resources` object
is "pure" scalar quantity i.e. its `Resource`(s) only has
name, type (set to scalar) and scalar fields set.
Also added tests.
Diffs (updated)
-----
include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
Diff: https://reviews.apache.org/r/67516/diff/2/
Changes: https://reviews.apache.org/r/67516/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67516: Added a resource utility `isScalarQuantity`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67516/#review205010
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/resources.hpp
Lines 328 (patched)
<https://reviews.apache.org/r/67516/#comment287859>
s/only consists of resource/consists of a resource/
src/tests/resources_tests.cpp
Lines 1964 (patched)
<https://reviews.apache.org/r/67516/#comment287860>
Maybe s/diskInfo/disk/ since this isn't a `DiskInfo` object?
- Greg Mann
On June 11, 2018, 5:34 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67516/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 5:34 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `isScalarQuantity()` checks if a `Resources` object
> is "pure" scalar quantity i.e. its `Resource`(s) only has
> name, type (set to scalar) and scalar fields set.
>
> Also added tests.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 7afe0d8090a5075faed22bd408310ae1bb464bce
> include/mesos/v1/resources.hpp c7120575d0dbfb9f8c9bb6b0cf9a4cea3d9f6932
> src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca
> src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1
> src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8
>
>
> Diff: https://reviews.apache.org/r/67516/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>