You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Zike Yang <zi...@apache.org> on 2025/03/07 03:11:38 UTC

Re: [improve][pip] PIP-406: Introduce metrics related to dispatch_throttled_count

Hi Baodi,

Good work. But I'm concerned about the names of these metrics. They
seem hard for users to understand. I've left some comments in the PR.

Also, is this thread a formal voting thread? If so, I suggest adding a
`[VOTE]` tag to the thread title for clarity.

Thanks,
Zike Yang

Re: [improve][pip] PIP-406: Introduce metrics related to dispatch_throttled_count

Posted by Zike Yang <zi...@apache.org>.
> For me, separating the metrics for messages and bytes makes it easier
for users to identify where the limitations are and adjust their
configurations accordingly.

Thanks for the explanation. That makes sense to me.

BR,
Zike Yang


On Fri, Mar 7, 2025 at 8:08 PM Baodi Shi <ba...@apache.org> wrote:
>
> hi, Zike.
>
> Thanks for review.
>
> For me, separating the metrics for messages and bytes makes it easier
> for users to identify where the limitations are and adjust their
> configurations accordingly.
>
> What do you think?
>
> > Also, is this thread a formal voting thread? If so, I suggest adding a
> `[VOTE]` tag to the thread title for clarity.
>
> Sorry, my mistake. Yes, let's discuss this in this thread first, and
> I'll start a voting thread later.
>
> Thanks,
> Baodi Shi
>
> Zike Yang <zi...@apache.org> 于2025年3月7日周五 11:13写道：
> >
> > Hi Baodi,
> >
> > Good work. But I'm concerned about the names of these metrics. They
> > seem hard for users to understand. I've left some comments in the PR.
> >
> > Also, is this thread a formal voting thread? If so, I suggest adding a
> > `[VOTE]` tag to the thread title for clarity.
> >
> > Thanks,
> > Zike Yang

Re: [improve][pip] PIP-406: Introduce metrics related to dispatch_throttled_count

Posted by Baodi Shi <ba...@apache.org>.
hi, Zike.

Thanks for review.

For me, separating the metrics for messages and bytes makes it easier
for users to identify where the limitations are and adjust their
configurations accordingly.

What do you think?

> Also, is this thread a formal voting thread? If so, I suggest adding a
`[VOTE]` tag to the thread title for clarity.

Sorry, my mistake. Yes, let's discuss this in this thread first, and
I'll start a voting thread later.

Thanks,
Baodi Shi

Zike Yang <zi...@apache.org> 于2025年3月7日周五 11:13写道：
>
> Hi Baodi,
>
> Good work. But I'm concerned about the names of these metrics. They
> seem hard for users to understand. I've left some comments in the PR.
>
> Also, is this thread a formal voting thread? If so, I suggest adding a
> `[VOTE]` tag to the thread title for clarity.
>
> Thanks,
> Zike Yang