You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by ocelotpotpie <gi...@git.apache.org> on 2014/03/25 17:31:21 UTC
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
GitHub user ocelotpotpie opened a pull request:
https://github.com/apache/couchdb/pull/195
COUCHDB-2210 Update d3 library.
This is an update of d3.js and nvd3.js to their latest versions.
Tested for backwards compatibility with existing d3 v2 charts in dashboard in:
* Google Chrome 33.0.1750.152
* Safari 7.0.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ocelotpotpie/couchdb 2210-update-d3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit c9e01d4d4216009973b415fb822f23288f2c0bca
Author: Christian Hogan <gi...@infliction.org>
Date: 2014-03-21T17:42:04Z
Updating d3 to v3.4.3 and nv.d3 to v1.1.15
commit d8d3de6f655097aecddd6016a0e414199c7cc317
Author: Christian Hogan <gi...@infliction.org>
Date: 2014-03-21T19:02:28Z
Require.js config to support d3 v3 update.
commit 26bfc51860c39adaaf1c53de9e05f9c94db7b351
Author: Christian Hogan <gi...@infliction.org>
Date: 2014-03-21T20:31:07Z
Updating d3 license year to match d3's official license.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/195#issuecomment-38594672
Compile fauxton with settings.json.default (so it's just the couchdb version of fauxton)
Then check out the stat's page.
there is a console log for nv.d3 that says "pie.values() is no longer supported. "
Can you fix that to use whatever nv.d3 uses now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/195#issuecomment-40758622
close this guy too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb/pull/195#issuecomment-38604489
@deathbearbrown Good catch! I updated the pie chart to reflect nvd3's removal of pie.values(), and tweaked some CSS. Should be a-okay now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/195#issuecomment-38608269
Looks great! +1 also yay for no inline styles!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie closed the pull request at:
https://github.com/apache/couchdb/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2210 Update d3 library.
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/195#issuecomment-42811976
@ocelotpotpie Can you close this PR. The has been merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---