[jira] [Resolved] (REEF-557) Move EnvironmentUtils.addAll to ConfigurationModule.set and delete EnvironmentUtils.addClasspath

["Markus Weimer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Weimer resolved REEF-557.
--------------------------------
    Resolution: Fixed

Resolved via [#336|https://github.com/apache/incubator-reef/pull/336]

> Move EnvironmentUtils.addAll to ConfigurationModule.set and delete EnvironmentUtils.addClasspath
> ------------------------------------------------------------------------------------------------
>
>                 Key: REEF-557
>                 URL: https://issues.apache.org/jira/browse/REEF-557
>             Project: REEF
>          Issue Type: Task
>          Components: Tang
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Minor
>             Fix For: 0.12
>
>
> As part of REEF-497 we need to deprecate {{addAll}} and {{addClasspath}} methods of {{EnvironmentUtils}}. We want to replace {{addAll}} with a {{ConfigurationModule.set}} method which would accept both {{Iterable<T>}} and {{T...}} as parameters. 
> The logic of {{addClasspath}} is not something we want to provide as an official library method. So we want to delete it and replace its usages in our code with {{addAll}} and explicit {{getAllClasspathJars()}} call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)