You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Vitalii Diravka (Jira)" <ji...@apache.org> on 2021/09/22 05:24:00 UTC

[jira] [Updated] (DRILL-7842) Fix BaseTestInheritance test case

     [ https://issues.apache.org/jira/browse/DRILL-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vitalii Diravka updated DRILL-7842:
-----------------------------------
    Description: 
*[Very minor, but can be good for newcomers]*

BaseTestInheritance test is not running in maven test phase. It is due to naming. The only tests starting from _Test*_ are running.

Need to rename it to _TestInheritanceFromBaseClass_ (for example) and fix tests, which are currently not inherited from the _BaseTest_ class:
{code:java}
[org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
 org.apache.drill.exec.physical.impl.TestStackAnalyzer,
 org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
 org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
 org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
 org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined]
{code}

  was:
*[Very minor, but can be good for newcomers]*

BaseTestInheritance test is not running in maven test phase. It is due to naming. The only tests starting from _Test*_ are running.

Need to rename it to _TestInheritanceFromBaseClass_ (for example) and fix tests, which are currently isn't inherited from the _BaseTest_ class:
{code:java}
[org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
 org.apache.drill.exec.physical.impl.TestStackAnalyzer,
 org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
 org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
 org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
 org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined]
{code}


> Fix BaseTestInheritance test case
> ---------------------------------
>
>                 Key: DRILL-7842
>                 URL: https://issues.apache.org/jira/browse/DRILL-7842
>             Project: Apache Drill
>          Issue Type: Test
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.18.0
>            Reporter: Vitalii Diravka
>            Priority: Trivial
>             Fix For: 1.19.0
>
>
> *[Very minor, but can be good for newcomers]*
> BaseTestInheritance test is not running in maven test phase. It is due to naming. The only tests starting from _Test*_ are running.
> Need to rename it to _TestInheritanceFromBaseClass_ (for example) and fix tests, which are currently not inherited from the _BaseTest_ class:
> {code:java}
> [org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
>  org.apache.drill.exec.physical.impl.TestStackAnalyzer,
>  org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
>  org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
>  org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
>  org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)