Re: [PR] Agent extension points: LlmClient/ConversationMemory SPI, connector-backed agent tools, event triggers (eventmesh)

["qqeasonchen (via GitHub)" <gi...@apache.org>]

qqeasonchen commented on PR #5408:
URL: https://github.com/apache/eventmesh/pull/5408#issuecomment-5757246756

   Rebased onto the latest develop (`2d1dc1a13`) to resolve the conflict with #5406's agent hardening.
   
   Conflict resolution notes:
   - `AgentApplication` — kept develop's #5405/#5406 hardening (LLM key fail-fast, heartbeat fail-limit exit, `maxConversations` LRU store) and layered the connector-tools registry + event-trigger wiring on top; runtime-url default fix from this PR was redundant for the agent module (develop already moved it to 10105) and is dropped in favor of develop's version
   - `ConversationStore` — develop's LRU-bounded version is the new base; this PR's change is now just `implements ConversationMemory` + `@Override` markers (both constructors preserved)
   - `agent.properties` — develop's #5405 keys kept; this PR's tool/trigger keys doc appended
   - Connector-runtime / examples port drift (8080 → 10105) is still needed on develop and remains part of this PR
   - Full javac + 9/9 unit tests re-verified against the merged sources


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org