[PR] Add parser IT cases for Oracle CREATE TABLE SQL from issue #27097 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39550:
URL: https://github.com/apache/shardingsphere/pull/39550

   - add sql-case and expected parser cases for ORGANIZATION EXTERNAL tables without ACCESS PARAMETERS, with parenthesized FIELDS TERMINATED BY access parameters, and with RECORDS VARIABLE n FIELDS TERMINATED BY ',' followed by a field list
   - add parser IT cases for PARTITION BY RANGE ... AS SELECT and composite range/hash partitioning with SUBPARTITION TEMPLATE and tablespaces
   
   Fixes #27097
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add parser IT cases for Oracle CREATE TABLE SQL from issue #27097 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39550:
URL: https://github.com/apache/shardingsphere/pull/39550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add parser IT cases for Oracle CREATE TABLE SQL from issue #27097 [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39550:
URL: https://github.com/apache/shardingsphere/pull/39550#issuecomment-5379052483

   ### Result
   **Review Result: Mergeable**
   
   This PR is a test-resource-only change (2 XML files, +69/-0) that adds parser IT cases for the five Oracle CREATE TABLE statements from issue #27097; the grammar support itself already landed in earlier merged commits, and this PR locks the behavior in. None of the three discovery lenses produced a blocking finding that passed the Finding Proof Gate.
   
   ### Evidence
   
   - Reviewed the latest public head `619146e0623` (identical to local HEAD; merge-base `17ac1b0e75d` equals the base ref). The local triple-dot changed-file list matches GitHub `/pulls/39550/files` exactly (2/2 matched, no one-sided difference).
   - The five new cases map one-to-one to the statements in issue #27097: `create_table_partition_by_range_subpartition_by_hash_with_template` (test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml:234), `create_table_partition_by_range_as_select` (same file:368), `create_table_organization_external` (:381), `create_table_with_fields_terminated_by` (:382), `create_table_with_records_variable_fields_terminated` (:383).
   - Each new sql-case-id appears exactly once on both the sql/supported and case/ddl sides (complete join). The expected assertions (table name, column definitions, and for CTAS the select projections/source table, with zero-based inclusive indices) follow the same assertion pattern as neighboring cases such as `create_table_partition_by_hash_parallel_as_select` and `create_table_with_records_variable`.
   - Verification run in this session on identical content (the pre-commit working tree matches the commit byte for byte): `./mvnw -pl test/it/parser -am -Dtest=...oracle.InternalOracleParserIT test` exited 0 with `Tests run: 1873, Failures: 0, Errors: 0`, and the five new case resources were confirmed copied into the test classpath and executed; `./mvnw spotless:apply -Pcheck -T1C` exited 0 with no formatting changes; `./mvnw checkstyle:check -Pcheck -pl test/it/parser` exited 0.
   - Candidate findings not adopted (all failed the proof gate): external-table clauses are not asserted in the AST — the Oracle visitor does not model that subtree, which is consistent with all neighboring cases, so the change is not required; single-line SQL versus the issue's multi-line text is semantically equivalent and matches repository convention; the repo-level checkstyle errors in `infra/common/.../SchemaMetaDataReviseEngineTest.java` come from an uncommitted checkstyle ruleset change of a separate parallel task, not from this PR's content (this PR only touches XML resources, outside checkstyle scope).
   
   ### Coverage
   
   - Reviewed head: `619146e0623` (1 commit, 2 files, +69/-0); requirements taken from the five statements in issue #27097 and the PR description.
   - Behavior clusters: 1 (Oracle CREATE TABLE parser IT case completion); both changed files are mapped to it with risk triage completed (root cause / linked-issue coverage, test validity, dialect boundary, regression risk, formatting and static checks); no churn-only files.
   - All three discovery lenses (root cause and behavior, blast radius and contracts, tests and runtime) are complete; the convergence pass found zero new candidates; no evidence gap remains that could change the blocker set.
   - Dialect scope: all new cases are `db-types="Oracle"`; Oracle is a trunk dialect with no branch dialects (per the CODE_OF_CONDUCT.md table), so other dialect ITs are unaffected. The syntax forms are taken verbatim from issue #27097 and no new syntax support is claimed, so no additional Oracle official documentation page is cited.
   - This verdict is a code-scope readiness conclusion under Code Correctness Review; GitHub Actions/CI state was not queried, awaited, or assessed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org