You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/09/03 12:17:29 UTC
[GitHub] incubator-brooklyn pull request: CreateUserPolicyWithEntityLiveTes...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/881
CreateUserPolicyWithEntityLiveTest
Verifies the behaviour of CreateUserPolicy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn create_user_policy_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/881.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #881
----
commit 4381cb988dd4e6de7e9f490ae262ad3fb0af55c9
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2015-09-03T10:16:26Z
CreateUserPolicyWithEntityLiveTest
Verifies the behaviour of CreateUserPolicy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: CreateUserPolicyWithEntityLiveTes...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/881#discussion_r38850867
--- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/CreateUserPolicyWithEntityLiveTest.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.entity.software.base;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import org.apache.brooklyn.api.entity.EntitySpec;
+import org.apache.brooklyn.api.policy.PolicySpec;
+import org.apache.brooklyn.core.test.BrooklynAppLiveTestSupport;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.policy.jclouds.os.CreateUserPolicy;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import java.util.Map;
+
+public class CreateUserPolicyWithEntityLiveTest extends BrooklynAppLiveTestSupport {
--- End diff --
The tests in this class make no assertions. What are they testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: CreateUserPolicyWithEntityLiveTes...
Posted by bostko <gi...@git.apache.org>.
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/881
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: CreateUserPolicyWithEntityLiveTes...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/881#issuecomment-138328758
I will close this PR in favor of #877
The purpose of `CreateUserPolicyWithEntityLiveTest` is to verify that it doesn't throw an exception.
@ygy could you please add this test and into your PR and assert isRunning is true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---