[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6837: Core, AWS: Allow disabling token refresh

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6837:
URL: https://github.com/apache/iceberg/pull/6837#discussion_r1114901292


##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -355,62 +357,52 @@ public static class AuthSession {
     private static final long MAX_REFRESH_WINDOW_MILLIS = 300_000; // 5 minutes
     private static final long MIN_REFRESH_WAIT_MILLIS = 10;
     private volatile Map<String, String> headers;
-    private volatile String token;
-    private volatile String tokenType;
-    private volatile Long expiresAtMillis;
-    private final String credential;
-    private final String scope;
-    private volatile boolean keepRefreshed = true;
+    private volatile AuthConfig config;
 
     /**
-     * @deprecated will be removed in 1.3.0; use {@link AuthSession#AuthSession(Map, String, String,
-     *     String, String)} instead.
+     * @deprecated will be removed in 1.3.0; use {@link AuthSession#AuthSession(Map, AuthConfig)}
+     *     instead.
      */
     @Deprecated
     public AuthSession(Map<String, String> baseHeaders, String token, String tokenType) {
-      this(baseHeaders, token, tokenType, null, OAuth2Properties.CATALOG_SCOPE);
+      this(baseHeaders, ImmutableAuthConfig.builder().token(token).tokenType(tokenType).build());

Review Comment:
   looks like we are still settling this debate?
   
   To me, overall using `AuthConfig` does seem cleaner, but why not just make `AuthSession` immutable in that case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org