You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "anguillanneuf (via GitHub)" <gi...@apache.org> on 2023/04/11 20:57:21 UTC
[GitHub] [pulsar-site] anguillanneuf opened a new pull request, #512: docs: typo
anguillanneuf opened a new pull request, #512:
URL: https://github.com/apache/pulsar-site/pull/512
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #512: docs: typo
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #512:
URL: https://github.com/apache/pulsar-site/pull/512#issuecomment-1504458439
@Anonymitaet Thanks for your information! Make sense.
Then one minor comment is to change `_ExclamationFunctio6_` to `ExclamationFunctio6` to avoid content mismatch. I'll push a follow-up and pending to merge this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] github-actions[bot] commented on pull request #512: docs: typo
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #512:
URL: https://github.com/apache/pulsar-site/pull/512#issuecomment-1504080714
@anguillanneuf Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #512: docs: typo
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #512:
URL: https://github.com/apache/pulsar-site/pull/512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #512: docs: typo
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #512:
URL: https://github.com/apache/pulsar-site/pull/512#issuecomment-1504447434
1. The original text is correct since the function name is `_ExclamationFunctio6_`?
<img width="1501" alt="image" src="https://user-images.githubusercontent.com/50226895/231330498-3f04be12-3b26-4b35-bb5e-e05b72a79a32.png">
2. Because you modify 2.11.x doc while previewing NEXT doc.
[Use `./preview.sh 2.11.x` if you want to preview 2.11.x doc changes.](https://pulsar.apache.org/contribute/document-preview/#preview-changes)
<img width="1158" alt="image" src="https://user-images.githubusercontent.com/50226895/231330986-fba22324-8433-4b91-9685-86f5e2b44ba9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on pull request #512: docs: typo
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #512:
URL: https://github.com/apache/pulsar-site/pull/512#issuecomment-1504462666
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org