You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2023/04/26 17:41:01 UTC
[hadoop] 11/14: HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads (#5274)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch feature-HADOOP-18028-s3a-prefetch-branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
commit 2c6f01c1b5051f9ece3008ae93160cad7293d8e3
Author: Ankit Saurabh <sa...@amazon.co.uk>
AuthorDate: Wed Feb 15 18:28:42 2023 +0000
HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads (#5274)
Contributed by Ankit Saurabh
---
.../hadoop/fs/impl/prefetch/CachingBlockManager.java | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java
index 31084c7bf26..a0db4b308b6 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java
@@ -302,7 +302,12 @@ public abstract class CachingBlockManager extends BlockManager {
private void read(BufferData data) throws IOException {
synchronized (data) {
- readBlock(data, false, BufferData.State.BLANK);
+ try {
+ readBlock(data, false, BufferData.State.BLANK);
+ } catch (IOException e) {
+ LOG.error("error reading block {}", data.getBlockNumber(), e);
+ throw e;
+ }
}
}
@@ -362,9 +367,6 @@ public abstract class CachingBlockManager extends BlockManager {
buffer.flip();
data.setReady(expectedState);
} catch (Exception e) {
- String message = String.format("error during readBlock(%s)", data.getBlockNumber());
- LOG.error(message, e);
-
if (isPrefetch && tracker != null) {
tracker.failed();
}
@@ -406,7 +408,8 @@ public abstract class CachingBlockManager extends BlockManager {
try {
blockManager.prefetch(data, taskQueuedStartTime);
} catch (Exception e) {
- LOG.error("error during prefetch", e);
+ LOG.info("error prefetching block {}. {}", data.getBlockNumber(), e.getMessage());
+ LOG.debug("error prefetching block {}", data.getBlockNumber(), e);
}
return null;
}
@@ -493,7 +496,8 @@ public abstract class CachingBlockManager extends BlockManager {
return;
}
} catch (Exception e) {
- LOG.error("error waiting on blockFuture: {}", data, e);
+ LOG.info("error waiting on blockFuture: {}. {}", data, e.getMessage());
+ LOG.debug("error waiting on blockFuture: {}", data, e);
data.setDone();
return;
}
@@ -523,8 +527,8 @@ public abstract class CachingBlockManager extends BlockManager {
data.setDone();
} catch (Exception e) {
numCachingErrors.incrementAndGet();
- String message = String.format("error adding block to cache after wait: %s", data);
- LOG.error(message, e);
+ LOG.info("error adding block to cache after wait: {}. {}", data, e.getMessage());
+ LOG.debug("error adding block to cache after wait: {}", data, e);
data.setDone();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org