[GitHub] [accumulo] ctubbsii commented on a change in pull request #1379: Improved metadata table consitency checking and testing

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1379: Improved metadata table consitency checking and testing
URL: https://github.com/apache/accumulo/pull/1379#discussion_r329721894
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/util/TabletIterator.java
 ##########
 @@ -101,6 +102,20 @@ public boolean hasNext() {
 
       currentTabletKeys = scanToPrevEndRow();
       if (currentTabletKeys.size() == 0) {
+        if (lastTablet != null) {
+          KeyExtent lastExtent = new KeyExtent(lastTablet, (Text) null);
+
+          if (lastExtent.getEndRow() != null) {
 
 Review comment:
   This part got a little confusing for me. A brief human-friendly comment might be helpful to explain this block's condition:
   
   ```suggestion
             // if lastTablet was not the default tablet
             if (lastExtent.getEndRow() != null) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services