[jclouds-chef] Remove public keyword from interface methods. (#33)

[Noorul Islam K M <no...@github.com>]

You can merge this Pull Request by running:

  git pull https://github.com/noorul/jclouds-chef remove_public_from_int_methods

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-chef/pull/33

-- Commit Summary --

  * Remove public keyword from interface methods.

-- File Changes --

    M core/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java (2)
    M core/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java (4)
    M core/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java (4)
    M core/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java (4)
    M core/src/main/java/org/jclouds/chef/strategy/ListClients.java (12)
    M core/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java (13)
    M core/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java (13)
    M core/src/main/java/org/jclouds/chef/strategy/ListNodes.java (12)
    M core/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java (12)
    M core/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds-chef/pull/33.patch
https://github.com/jclouds/jclouds-chef/pull/33.diff

Re: [jclouds-chef] Remove public keyword from interface methods. (#33)

[Noorul Islam K M <no...@github.com>]

Using that command, I found one more in jclouds-chef and submitted a PR

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/33#issuecomment-27409486

Re: [jclouds-chef] Remove public keyword from interface methods. (#33)

[Andrew Gaul <no...@github.com>]

@nacx good suggestion, opened #193.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/33#issuecomment-27443564

Re: [jclouds-chef] Remove public keyword from interface methods. (#33)

[CloudBees pull request builder plugin <no...@github.com>]

[jclouds-chef-pull-requests #85](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/85/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/33#issuecomment-27384106

Re: [jclouds-chef] Remove public keyword from interface methods. (#33)

[Andrew Gaul <no...@github.com>]

Pushed to master.  Any suggestions on how to prevent these in the future, e.g., Google error-prone?  I found several instances in jclouds itself with:

find -name \*.java | xargs grep -l '^public interface' | xargs grep '^  *public' | grep -v -e static -e {

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/33#issuecomment-27405282

Re: [jclouds-chef] Remove public keyword from interface methods. (#33)

[Ignasi Barrera <no...@github.com>]

Perhaps we could add the RedundantModifier to our checkstyle config?

http://checkstyle.sourceforge.net/config_modifier.html

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/33#issuecomment-27417081