You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/23 11:38:03 UTC

[GitHub] [incubator-kvrocks] jasonhe88 opened a new issue, #1132: lua script load return bool true (PHP client)

jasonhe88 opened a new issue, #1132:
URL: https://github.com/apache/incubator-kvrocks/issues/1132

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Version
   
   MacOS 12.2.1
   KVRocks 2.1.0
   
   ### Minimal reproduce step
   
   ```php
    <?php
     
    $redis = new Redis();
     
    $redis->connect('127.0.0.1', 6379);
     
   $r = $redis->script('load', 'return "hello"');
   var_dump($r);
   ```
   
   ### What did you expect to see?
   
   hash value of lua script
   
   ### What did you see instead?
   
   bool(true)
   
   ### Anything Else?
   
   if switch to Redis, above code return correct hash value
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1132: lua script load return bool true (PHP client)

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #1132:
URL: https://github.com/apache/incubator-kvrocks/issues/1132#issuecomment-1325048719

   @jasonhe88 Are you using `phpredis`? if yes, you can workaround by using the `raw` command to send the `script load` which will parse the simple string as string(except in the pipeline or multi mode): https://github.com/phpredis/phpredis/blob/b580505b40ef8b182ca79d49cda38c7d1ea9b5c7/redis.c#L3070
   
   
   For the raw command, you can have a look at: https://github.com/phpredis/phpredis#rawcommand
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jasonhe88 commented on issue #1132: lua script load return bool true (PHP client)

Posted by GitBox <gi...@apache.org>.
jasonhe88 commented on issue #1132:
URL: https://github.com/apache/incubator-kvrocks/issues/1132#issuecomment-1324982539

   thank you for your quick response
   
   is there any workaround to resolve this issue?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1132: lua script load return bool true (PHP client)

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #1132:
URL: https://github.com/apache/incubator-kvrocks/issues/1132#issuecomment-1324952341

   @jasonhe88 Thanks for your feedback. You're right that's a bug which caused by Kvrocks return the inconsistent string with Redis.
   
   Expected is bulk string(`$40\r\n{SHA}\r\n`) but returned the simple string(`+{SHA}\r\n`) indeed. Refer: https://github.com/apache/incubator-kvrocks/blame/unstable/src/commands/redis_cmd.cc#L5036


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jasonhe88 commented on issue #1132: lua script load return bool true (PHP client)

Posted by GitBox <gi...@apache.org>.
jasonhe88 commented on issue #1132:
URL: https://github.com/apache/incubator-kvrocks/issues/1132#issuecomment-1325281153

   Get it, Thank you so much!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] jasonhe88 closed issue #1132: lua script load return bool true (PHP client)

Posted by GitBox <gi...@apache.org>.
jasonhe88 closed issue #1132: lua script load return bool true (PHP client)
URL: https://github.com/apache/incubator-kvrocks/issues/1132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org