Re: [PR] Fix TaskHandlerWithCustomFormatter now adds prefix only once [airflow]

["Lee-W (via GitHub)" <gi...@apache.org>]

Lee-W commented on code in PR #38502:
URL: https://github.com/apache/airflow/pull/38502#discussion_r1540379167


##########
airflow/utils/log/task_handler_with_custom_formatter.py:
##########
@@ -45,7 +45,7 @@ def set_context(self, ti) -> None:
         :param ti:
         :return:
         """
-        if ti.raw or self.formatter is None:
+        if ti.raw or self.formatter is None or self.prefix_jinja_template is not None:

Review Comment:
   Not sure whether we should add a comment on why `self.prefix_jinja_template is not None:` is added. It might not be that straightforward when looking at this condition alone. Also, could we also add a test case for it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org