Re: [PR] Support system theme [airflow]

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #52649:
URL: https://github.com/apache/airflow/pull/52649#discussion_r2291204153


##########
airflow-core/src/airflow/ui/src/context/colorMode/useColorMode.tsx:
##########
@@ -19,14 +19,11 @@
 import { useTheme } from "next-themes";
 
 export const useColorMode = () => {
-  const { resolvedTheme, setTheme } = useTheme();
-  const toggleColorMode = () => {
-    setTheme(resolvedTheme === "light" ? "dark" : "light");
-  };

Review Comment:
   Why did we remove `toggleColorMode`? Can you make this a copy of the `useColormode.tsx` in core UI ? 
   
   Ideally I'll move this to be a symlink of the original file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org