You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "nenb (via GitHub)" <gi...@apache.org> on 2023/06/02 11:41:49 UTC
[GitHub] [arrow] nenb opened a new pull request, #35887: MINOR: [Docs] Fix typo in docs for dense union data type
nenb opened a new pull request, #35887:
URL: https://github.com/apache/arrow/pull/35887
## Rationale for this change / What changes are included in this PR?
Fixed typo in `Columnar.rst`.
I think this typo may have crept in from an [older](https://wesm.github.io/arrow-site-test/format/Layout.html#example-layout-dense-union) version of the docs when validity bitmaps were allowed for Union types.
## Are these changes tested?
N/A
## Are there any user-facing changes?
Only in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF merged pull request #35887: MINOR: [Docs] Fix typo in docs for dense union data type
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #35887:
URL: https://github.com/apache/arrow/pull/35887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35887: MINOR: [Docs] Fix typo in docs for dense union data type
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35887:
URL: https://github.com/apache/arrow/pull/35887#issuecomment-1586342928
Benchmark runs are scheduled for baseline = fe6093228fd27e902b83031d09eef2765d615ed7 and contender = fe48403651e51e241802fef05984efc37f10a4fc. fe48403651e51e241802fef05984efc37f10a4fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8b17203e77cb4ea6a583e98649e2d9e8...0539132d4b604589afba35bc91f10482/)
[Finished :arrow_down:1.06% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2846772bc9dd471480d7aa1f794ef8ff...4963865010db48439c3b73cf86d2082b/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9a3dc82f9ae9438fa76f79dc52d810b3...0c6e9752a46343a293aa9dd8bc6b73a3/)
[Finished :arrow_down:1.19% :arrow_up:0.3%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ab5349fb62f942e2b2b25552f096ab02...a52aa07d86c645878387c462254b497c/)
Buildkite builds:
[Finished] [`fe484036` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3021)
[Finished] [`fe484036` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3057)
[Finished] [`fe484036` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3022)
[Finished] [`fe484036` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3047)
[Finished] [`fe609322` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3020)
[Finished] [`fe609322` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3056)
[Finished] [`fe609322` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3021)
[Finished] [`fe609322` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3046)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nenb commented on pull request #35887: MINOR: [Docs] Fix typo in docs for dense union data type
Posted by "nenb (via GitHub)" <gi...@apache.org>.
nenb commented on PR #35887:
URL: https://github.com/apache/arrow/pull/35887#issuecomment-1585757267
@AlenkaF Apologies for the notification, I wasn't sure how else to add a reviewer.
Please do let me know if this not good behaviour, and what I should do in future.
Thanks for all your work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #35887: MINOR: [Docs] Fix typo in docs for dense union data type
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #35887:
URL: https://github.com/apache/arrow/pull/35887#issuecomment-1586240830
Thank you for the contribution @nenb, pinging me like this is fine for sure 👍
I think the change is correct. The null count is now added to the first child array (field `f`), so the length of this array has to be increased by 1.
Will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org