You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2024/01/12 02:14:29 UTC
[PR] Made some minor adjustments to the KLL toString(boolean, boolean) methods. (datasketches-java)
leerho opened a new pull request, #491:
URL: https://github.com/apache/datasketches-java/pull/491
These changes make it easier to control what exactly is printed.
The toString() method in KllSketch should have been abstract. Changed the parameter names to be consistent with what is actually implemented.
The Kll Items, Floats and Doubles Classes override the KllSketch methods. This is not new. I just changed the parameter names to match the actual impl method in KllHelper.
In KllHelper I made printing the summary the default and it always prints. In addition, the user can choose to print a small summary of the Levels information, and /or the detail of the entire ItemsArray.
All of these options were there before. Just the parameters didn't describe them very well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Made some minor adjustments to the KLL toString(boolean, boolean) methods. (datasketches-java)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #491:
URL: https://github.com/apache/datasketches-java/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org