You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@shadyvale.net> on 2004/03/19 19:39:28 UTC

[PATCH] Avoid treating urls as paths

This passes all ra_local tests and manual testing.  If it passes the 
other test suites and there's no objections, I'll commit it in a day or two.

Log:
Avoid calling svn_cmdline_path_local_style_from_utf8 on urls
which turns forward slashes into backslashes on Windows.

* subversion/clients/cmdline/propget-cmd.c
   (svn_cl__propget): Call svn_utf_cstring_from_utf8 if it's a url.
* subversion/clients/cmdline/proplist-cmd.c
   (svn_cl__proplist): Call svn_utf_cstring_from_utf8 if it's a url.


Re: [PATCH] Avoid treating urls as paths

Posted by "D.J. Heap" <dj...@shadyvale.net>.
D.J. Heap wrote:
> This passes all ra_local tests and manual testing.  If it passes the 
> other test suites and there's no objections, I'll commit it in a day or 
> two.
> 
> Log:
> Avoid calling svn_cmdline_path_local_style_from_utf8 on urls
> which turns forward slashes into backslashes on Windows.
> 
> * subversion/clients/cmdline/propget-cmd.c
>   (svn_cl__propget): Call svn_utf_cstring_from_utf8 if it's a url.
> * subversion/clients/cmdline/proplist-cmd.c
>   (svn_cl__proplist): Call svn_utf_cstring_from_utf8 if it's a url.


After getting ready to commit this, I decided it must not be quite right 
-- other areas of the commandline client use 
svn_cmdline_cstring_from_utf8 rather than svn_utf_cstring_from_utf8 to 
ensure proper handling of language encodings when outputting to the 
console...such as the author and date in the log callback.  I've tweaked 
the log message callback with this patch also, but I can break that into 
a separate patch if that's more desirable.

I think it's correct now, but it'd be nice if someone with more 
encoding-fu could review it (Brane or ?).

Log:
Avoid calling svn_cmdline_path_local_style_from_utf8 on urls
which turns forward slashes into backslashes on Windows and
make sure log output is translated correctly.

* subversion/clients/cmdline/propget-cmd.c
  (svn_cl__propget): Call svn_cmdline_cstring_from_utf8 if it's a url.
* subversion/clients/cmdline/proplist-cmd.c
  (svn_cl__proplist): Call svn_cmdline_cstring_from_utf8 if it's a url.
* subversion/clients/cmdline/log-cmd.c
  (log_message_receiver): Use svn_cmdline_cstring_from_utf8 on the
   changed paths to ensure correct translation.