You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2009/01/29 00:02:59 UTC
[jira] Created: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
RPC call throws IllegalArgumentException complaining duplicate metrics registration
-----------------------------------------------------------------------------------
Key: HADOOP-5139
URL: https://issues.apache.org/jira/browse/HADOOP-5139
Project: Hadoop Core
Issue Type: Bug
Components: ipc
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.19.1
Here is the error log:
INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:396)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668526#action_12668526 ]
Hadoop QA commented on HADOOP-5139:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12398950/rpcException.patch
against trunk revision 738837.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3773/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3773/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3773/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3773/console
This message is automatically generated.
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.1
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5139:
----------------------------------
Attachment: rpcException.patch
Here is a patch that fixes the problem.
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.1
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5139:
----------------------------------
Status: Patch Available (was: Open)
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.1
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673945#action_12673945 ]
Hudson commented on HADOOP-5139:
--------------------------------
Integrated in Hadoop-trunk #756 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/])
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.20.0
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668215#action_12668215 ]
Hairong Kuang commented on HADOOP-5139:
---------------------------------------
The problem is that the RPC server first checks if a metrics is registered; if no, it then register the metrics. However, check/register is not synchronized. So although the first check reports the metrics is not registered, the metrics may be registered by another thread before this thread registers it.
I propose that IPC server catches the exception and fetches the metrics handle again.
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.1
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5139:
-------------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.1)
0.20.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Hairong!
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.20.0
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5139) RPC call throws
IllegalArgumentException complaining duplicate metrics registration
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5139:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5139
> URL: https://issues.apache.org/jira/browse/HADOOP-5139
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.1
>
> Attachments: rpcException.patch
>
>
> Here is the error log:
> INFO ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
> java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
> at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
> at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:396)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.