You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/03 13:56:04 UTC
Review Request 39899: Code to read keysdir cannot handle space in the
front
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39899/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Myroslav Papirkovskyy.
Bugs: AMBARI-13694
https://issues.apache.org/jira/browse/AMBARI-13694
Repository: ambari
Description
-------
It seems that after ambari agent upgrade spaces get added before and after = in the .ini file.
pre-upgrade
keysdir=/var/lib/ambari-agent/keys
post upgrade
keysdir = /var/lib/ambari-agent/keys
This result in:
chown: cannot access ` /var/lib/ambari-agent/keys': No such file or directory
...
[root@c6401 vagrant]# ambari-agent start
Verifying Python version compatibility...
Using python /usr/bin/python2.6
Checking for previously running Ambari Agent...
chown: cannot access ` /var/lib/ambari-agent/keys': No such file or directory
Starting ambari-agent
Verifying ambari-agent process status...
Ambari Agent successfully started
Diffs
-----
ambari-agent/conf/unix/ambari-agent ea59216
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 03e14ad
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py a583131
ambari-agent/src/test/python/ambari_agent/TestAmbariConfig.py PRE-CREATION
Diff: https://reviews.apache.org/r/39899/diff/
Testing
-------
All unit tests passed
----------------------------------------------------------------------
Ran 420 tests in 8.127s
OK
Thanks,
Dmytro Sen
Re: Review Request 39899: Code to read keysdir cannot handle space in
the front
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39899/#review104909
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 3, 2015, 2:56 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39899/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 2:56 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-13694
> https://issues.apache.org/jira/browse/AMBARI-13694
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It seems that after ambari agent upgrade spaces get added before and after = in the .ini file.
> pre-upgrade
> keysdir=/var/lib/ambari-agent/keys
> post upgrade
> keysdir = /var/lib/ambari-agent/keys
> This result in:
>
> chown: cannot access ` /var/lib/ambari-agent/keys': No such file or directory
> ...
>
> [root@c6401 vagrant]# ambari-agent start
> Verifying Python version compatibility...
> Using python /usr/bin/python2.6
> Checking for previously running Ambari Agent...
> chown: cannot access ` /var/lib/ambari-agent/keys': No such file or directory
> Starting ambari-agent
> Verifying ambari-agent process status...
> Ambari Agent successfully started
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent ea59216
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 03e14ad
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py a583131
> ambari-agent/src/test/python/ambari_agent/TestAmbariConfig.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39899/diff/
>
>
> Testing
> -------
>
> All unit tests passed
>
> ----------------------------------------------------------------------
> Ran 420 tests in 8.127s
>
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>