You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2014/01/22 03:58:21 UTC
Re: Review Request 17148: FALCON-123 Improve build speeds in falcon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17148/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 2:58 a.m.)
Review request for Falcon.
Summary (updated)
-----------------
FALCON-123 Improve build speeds in falcon
Bugs: FALCON-123
https://issues.apache.org/jira/browse/FALCON-123
Repository: falcon-git
Description
-------
Currently default build includes javadocs generation, sources packaging, checkstyle verification & findbugs verification besides whole lots of unit tests and integration tests. It would be good to move some of these to test-patch (verified by hudson) and during nightly builds.
Diffs (updated)
-----
acquisition/pom.xml e2017dd
archival/pom.xml c43e645
build-tools/pom.xml 7a020d3
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced
common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java 10a9cc0
common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 6917472
common/src/test/resources/runtime.properties PRE-CREATION
feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java 128784e
hadoop-dependencies/pom.xml 225b9d9
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java PRE-CREATION
hadoop-dependencies/src/main/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider PRE-CREATION
hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java PRE-CREATION
hadoop-webapp/pom.xml 7640883
hadoop-webapp/src/main/java/org/apache/falcon/JobTrackerService.java PRE-CREATION
hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java c2bb6f7
hadoop-webapp/src/main/resources/core-site.xml 484e904
hadoop-webapp/src/main/resources/hive-site.xml 49cda78
hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5
hadoop-webapp/src/test/java/org/apache/hadoop/mapred/LocalRunnerTest.java PRE-CREATION
hadoop-webapp/src/versioned-src/v1/java/org/apache/hadoop/mapred/LocalRunnerV1.java PRE-CREATION
hadoop-webapp/src/versioned-src/v2/java/org/apache/hadoop/mapred/LocalRunnerV2.java PRE-CREATION
messaging/pom.xml a59c1e3
messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java 27bea68
messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java a1609af
messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 078b9c2
metrics/pom.xml 1ed4f6b
oozie-el-extensions/pom.xml 4c76c89
pom.xml 36c5f7a
process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 794e585
test-util/pom.xml 6bd4129
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java c443e05
test-util/src/main/resources/core-site.xml PRE-CREATION
webapp/pom.xml 0c2d844
webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d
webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7
webapp/src/conf/oozie/conf/oozie-site.xml 48408ba
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java c4d6671
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728
webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java PRE-CREATION
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 9b672f4
webapp/src/test/java/org/apache/falcon/logging/LogMoverIT.java e3cd914
webapp/src/test/java/org/apache/falcon/logging/LogProviderIT.java 4c3ce97
webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java aa059bd
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java PRE-CREATION
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ac15391
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc
webapp/src/test/resources/cluster-template.xml 32eb643
Diff: https://reviews.apache.org/r/17148/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 17148: FALCON-123 Improve build speeds in falcon
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17148/#review33314
-----------------------------------------------------------
Ship it!
Ship It!
- Srikanth Sundarrajan
On Jan. 22, 2014, 9:38 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17148/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 9:38 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-123
> https://issues.apache.org/jira/browse/FALCON-123
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently default build includes javadocs generation, sources packaging, checkstyle verification & findbugs verification besides whole lots of unit tests and integration tests. It would be good to move some of these to test-patch (verified by hudson) and during nightly builds.
>
>
> Diffs
> -----
>
> acquisition/pom.xml e2017dd
> archival/pom.xml c43e645
> build-tools/pom.xml 7a020d3
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced
> common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java 10a9cc0
> common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 6917472
> common/src/test/resources/runtime.properties PRE-CREATION
> feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java 128784e
> hadoop-dependencies/pom.xml 225b9d9
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java PRE-CREATION
> hadoop-dependencies/src/main/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider PRE-CREATION
> hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java PRE-CREATION
> hadoop-webapp/pom.xml 7640883
> hadoop-webapp/src/main/java/org/apache/falcon/JobTrackerService.java PRE-CREATION
> hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java c2bb6f7
> hadoop-webapp/src/main/resources/core-site.xml 484e904
> hadoop-webapp/src/main/resources/hive-site.xml 49cda78
> hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5
> hadoop-webapp/src/test/java/org/apache/hadoop/mapred/LocalRunnerTest.java PRE-CREATION
> hadoop-webapp/src/versioned-src/v1/java/org/apache/hadoop/mapred/LocalRunnerV1.java PRE-CREATION
> hadoop-webapp/src/versioned-src/v2/java/org/apache/hadoop/mapred/LocalRunnerV2.java PRE-CREATION
> messaging/pom.xml a59c1e3
> messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java 27bea68
> messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java a1609af
> messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 078b9c2
> metrics/pom.xml 1ed4f6b
> oozie-el-extensions/pom.xml 4c76c89
> pom.xml 36c5f7a
> process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 794e585
> test-util/pom.xml 6bd4129
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java c443e05
> test-util/src/main/resources/core-site.xml PRE-CREATION
> webapp/pom.xml 0c2d844
> webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d
> webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7
> webapp/src/conf/oozie/conf/oozie-site.xml 48408ba
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java c4d6671
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java PRE-CREATION
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 9b672f4
> webapp/src/test/java/org/apache/falcon/logging/LogMoverIT.java e3cd914
> webapp/src/test/java/org/apache/falcon/logging/LogProviderIT.java 4c3ce97
> webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java aa059bd
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java PRE-CREATION
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ac15391
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc
> webapp/src/test/resources/cluster-template.xml 32eb643
>
> Diff: https://reviews.apache.org/r/17148/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 17148: FALCON-123 Improve build speeds in falcon
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17148/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 9:38 a.m.)
Review request for Falcon.
Bugs: FALCON-123
https://issues.apache.org/jira/browse/FALCON-123
Repository: falcon-git
Description
-------
Currently default build includes javadocs generation, sources packaging, checkstyle verification & findbugs verification besides whole lots of unit tests and integration tests. It would be good to move some of these to test-patch (verified by hudson) and during nightly builds.
Diffs (updated)
-----
acquisition/pom.xml e2017dd
archival/pom.xml c43e645
build-tools/pom.xml 7a020d3
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced
common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java 10a9cc0
common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 6917472
common/src/test/resources/runtime.properties PRE-CREATION
feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java 128784e
hadoop-dependencies/pom.xml 225b9d9
hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java PRE-CREATION
hadoop-dependencies/src/main/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider PRE-CREATION
hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java PRE-CREATION
hadoop-webapp/pom.xml 7640883
hadoop-webapp/src/main/java/org/apache/falcon/JobTrackerService.java PRE-CREATION
hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java c2bb6f7
hadoop-webapp/src/main/resources/core-site.xml 484e904
hadoop-webapp/src/main/resources/hive-site.xml 49cda78
hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5
hadoop-webapp/src/test/java/org/apache/hadoop/mapred/LocalRunnerTest.java PRE-CREATION
hadoop-webapp/src/versioned-src/v1/java/org/apache/hadoop/mapred/LocalRunnerV1.java PRE-CREATION
hadoop-webapp/src/versioned-src/v2/java/org/apache/hadoop/mapred/LocalRunnerV2.java PRE-CREATION
messaging/pom.xml a59c1e3
messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java 27bea68
messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java a1609af
messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 078b9c2
metrics/pom.xml 1ed4f6b
oozie-el-extensions/pom.xml 4c76c89
pom.xml 36c5f7a
process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 794e585
test-util/pom.xml 6bd4129
test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java c443e05
test-util/src/main/resources/core-site.xml PRE-CREATION
webapp/pom.xml 0c2d844
webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d
webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7
webapp/src/conf/oozie/conf/oozie-site.xml 48408ba
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java c4d6671
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728
webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java PRE-CREATION
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 9b672f4
webapp/src/test/java/org/apache/falcon/logging/LogMoverIT.java e3cd914
webapp/src/test/java/org/apache/falcon/logging/LogProviderIT.java 4c3ce97
webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java aa059bd
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java PRE-CREATION
webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ac15391
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc
webapp/src/test/resources/cluster-template.xml 32eb643
Diff: https://reviews.apache.org/r/17148/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 17148: FALCON-123 Improve build speeds in falcon
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17148/#review32478
-----------------------------------------------------------
Minor comments. Looks good otherwise. Thanks Srikanth
build-tools/pom.xml
<https://reviews.apache.org/r/17148/#comment61346>
Build-tools doesn't have any code. Does it need testng?
hadoop-dependencies/pom.xml
<https://reviews.apache.org/r/17148/#comment61351>
Shouldn't the exclusions go into dependency management in parent pom?
- shwethags
On Jan. 22, 2014, 2:58 a.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17148/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-123
> https://issues.apache.org/jira/browse/FALCON-123
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently default build includes javadocs generation, sources packaging, checkstyle verification & findbugs verification besides whole lots of unit tests and integration tests. It would be good to move some of these to test-patch (verified by hudson) and during nightly builds.
>
>
> Diffs
> -----
>
> acquisition/pom.xml e2017dd
> archival/pom.xml c43e645
> build-tools/pom.xml 7a020d3
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced
> common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java 10a9cc0
> common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 6917472
> common/src/test/resources/runtime.properties PRE-CREATION
> feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java 128784e
> hadoop-dependencies/pom.xml 225b9d9
> hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java PRE-CREATION
> hadoop-dependencies/src/main/services/org.apache.hadoop.mapreduce.protocol.ClientProtocolProvider PRE-CREATION
> hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java PRE-CREATION
> hadoop-webapp/pom.xml 7640883
> hadoop-webapp/src/main/java/org/apache/falcon/JobTrackerService.java PRE-CREATION
> hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java c2bb6f7
> hadoop-webapp/src/main/resources/core-site.xml 484e904
> hadoop-webapp/src/main/resources/hive-site.xml 49cda78
> hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5
> hadoop-webapp/src/test/java/org/apache/hadoop/mapred/LocalRunnerTest.java PRE-CREATION
> hadoop-webapp/src/versioned-src/v1/java/org/apache/hadoop/mapred/LocalRunnerV1.java PRE-CREATION
> hadoop-webapp/src/versioned-src/v2/java/org/apache/hadoop/mapred/LocalRunnerV2.java PRE-CREATION
> messaging/pom.xml a59c1e3
> messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java 27bea68
> messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java a1609af
> messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 078b9c2
> metrics/pom.xml 1ed4f6b
> oozie-el-extensions/pom.xml 4c76c89
> pom.xml 36c5f7a
> process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 794e585
> test-util/pom.xml 6bd4129
> test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java c443e05
> test-util/src/main/resources/core-site.xml PRE-CREATION
> webapp/pom.xml 0c2d844
> webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d
> webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7
> webapp/src/conf/oozie/conf/oozie-site.xml 48408ba
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java c4d6671
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java PRE-CREATION
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 9b672f4
> webapp/src/test/java/org/apache/falcon/logging/LogMoverIT.java e3cd914
> webapp/src/test/java/org/apache/falcon/logging/LogProviderIT.java 4c3ce97
> webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java aa059bd
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java PRE-CREATION
> webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ac15391
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc
> webapp/src/test/resources/cluster-template.xml 32eb643
>
> Diff: https://reviews.apache.org/r/17148/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>