[GitHub] [spark] amaliujia commented on a diff in pull request #38147: [SPARK-40585][SQL] Double-quoted identifiers should be available only in ANSI mode

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38147:
URL: https://github.com/apache/spark/pull/38147#discussion_r990493388


##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
 -- !query schema
 struct<>
 -- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException

Review Comment:
   I am seeing there is an extra testing here:
   
   so this test file itself contains both `double_quoted_identifiers=false` and `double_quoted_identifiers=true` and now we run it into both ANSI and non-ANSI.
   
   So I think what the unique testing coverage is:
   1. non-ANSI and `double_quoted_identifiers=false`, so double quoted is still a string.
   2. non-ANSI and `double_quoted_identifiers=true`, so we see parser exception.
   3. ANSI and `double_quoted_identifiers=true`, this feature is on and being tested.
   
   But for ANSI and `double_quoted_identifiers=false` which seems to be the same as number 2 above?



##########
sql/core/src/test/resources/sql-tests/results/double-quoted-identifiers.sql.out:
##########
@@ -277,74 +277,110 @@ SELECT 1 FROM "not_exist"
 -- !query schema
 struct<>
 -- !query output
-org.apache.spark.sql.AnalysisException
-Table or view not found: not_exist; line 1 pos 14
+org.apache.spark.sql.catalyst.parser.ParseException

Review Comment:
   I am seeing there might be an extra testing here:
   
   so this test file itself contains both `double_quoted_identifiers=false` and `double_quoted_identifiers=true` and now we run it into both ANSI and non-ANSI.
   
   So I think what the unique testing coverage is:
   1. non-ANSI and `double_quoted_identifiers=false`, so double quoted is still a string.
   2. non-ANSI and `double_quoted_identifiers=true`, so we see parser exception.
   3. ANSI and `double_quoted_identifiers=true`, this feature is on and being tested.
   
   But for ANSI and `double_quoted_identifiers=false` which seems to be the same as number 2 above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org