You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/04 01:08:49 UTC
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13442: Support openGauss insert on duplicate key
strongduanmu commented on a change in pull request #13442:
URL: https://github.com/apache/shardingsphere/pull/13442#discussion_r742456119
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-opengauss/src/main/antlr4/imports/opengauss/DMLStatement.g4
##########
@@ -48,15 +48,13 @@ insertColumnItem
: colId optIndirection
;
-optOnConflict
Review comment:
@tuichenchuxin Does openGauss support this PostgreSQL statement?
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/dml/insert.xml
##########
@@ -1943,4 +1943,54 @@
</value>
</values>
</insert>
+
+ <insert sql-case-id="insert_on_duplicate_key_update_nothing">
+ <table name="t_order" start-index="12" stop-index="18" />
+ <columns start-index="20" stop-index="46">
+ <column name="order_id" start-index="21" stop-index="28" />
+ <column name="user_id" start-index="31" stop-index="37" />
+ <column name="status" start-index="40" stop-index="45" />
+ </columns>
+ <values>
+ <value>
+ <assignment-value>
+ <parameter-marker-expression value="0" />
+ <literal-expression value="1" start-index="56" stop-index="56" />
+ </assignment-value>
+ <assignment-value>
+ <parameter-marker-expression value="1" />
+ <literal-expression value="1" start-index="59" stop-index="59" />
+ </assignment-value>
+ <assignment-value>
+ <parameter-marker-expression value="2" />
+ <literal-expression value="insert" start-index="62" stop-index="69" />
+ </assignment-value>
+ </value>
+ </values>
+ </insert>
+
+ <insert sql-case-id="insert_on_duplicate_key_update_multi_column">
+ <table name="t_order" start-index="12" stop-index="18" />
+ <columns start-index="20" stop-index="46">
+ <column name="order_id" start-index="21" stop-index="28" />
+ <column name="user_id" start-index="31" stop-index="37" />
+ <column name="status" start-index="40" stop-index="45" />
+ </columns>
+ <values>
+ <value>
+ <assignment-value>
+ <parameter-marker-expression value="0" />
+ <literal-expression value="1" start-index="56" stop-index="56" />
+ </assignment-value>
+ <assignment-value>
+ <parameter-marker-expression value="1" />
+ <literal-expression value="1" start-index="59" stop-index="59" />
+ </assignment-value>
+ <assignment-value>
+ <parameter-marker-expression value="2" />
+ <literal-expression value="insert" start-index="62" stop-index="69" />
+ </assignment-value>
Review comment:
@tuichenchuxin Why not parse `on duplicate key update` clause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org