You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/01/29 01:59:01 UTC
[PR] [#1407] feat(rust): support metrics about disk and topN data size [incubator-uniffle]
zuston opened a new pull request, #1488:
URL: https://github.com/apache/incubator-uniffle/pull/1488
### What changes were proposed in this pull request?
1. feat(rust): add more metrics about local disk and reading
2. feat(rust): support topN app data size
### Why are the changes needed?
Fix: #1407
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1407] feat(rust): support metrics about disk and topN data size [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1488:
URL: https://github.com/apache/incubator-uniffle/pull/1488#issuecomment-1913843533
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`882cc20`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/882cc208256f5b9b7d360e84ec0bb0f0c289473f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.24% compared to head [(`a6d0262`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1488?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.80%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1488 +/- ##
============================================
+ Coverage 54.24% 54.80% +0.56%
+ Complexity 2804 2272 -532
============================================
Files 427 350 -77
Lines 24347 15749 -8598
Branches 2075 1445 -630
============================================
- Hits 13207 8632 -4575
+ Misses 10310 6624 -3686
+ Partials 830 493 -337
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1488?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1407] feat(rust): support metrics about disk and topN data size [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1488:
URL: https://github.com/apache/incubator-uniffle/pull/1488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org