You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/03 08:31:08 UTC

[GitHub] [flink] simpleusr opened a new pull request #14846: checkpoint problem

simpleusr opened a new pull request #14846:
URL: https://github.com/apache/flink/pull/14846


   Hi
   
    
   
   I am trying to upgrade from 1.5.5 to 1.12 and checkpointing mechanism seems to be broken in our kafka connector sourced datastream jobs.
   
    
   
   Since there is a siginificant version gap and there are many backwards uncompatible / deprecated changes in flink runtime between versions, I had to modify our jobs and noticed that checkpoint offsets are not committed to kafka for source connectors.
   
    
   
   To simplfiy the issues I created simple repoducer projects:
   
    
   
   https://github.com/simpleusr/flink_problem_1.5.5
   
   https://github.com/simpleusr/flink_problem_1.12.0
   
    
   
   It seems that there are majr changes in the checkpoint infrastructure.
   
    
   
   For 1.5.5 checkpoint cycles works as expected as can be seen from the logs (please note that sample project contains a small hack in org.apache.flink.runtime.minicluster.MiniCluster which prevents cluster from stopping) :
   
   
   
    **[2021-02-03 10:04:17,409] INFO Completed checkpoint 2 for job 08eb15132225903b77ee44f5ca6ad2a5 (43764 bytes in 11 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:873)**
   
   **[2021-02-03 10:04:17,409] INFO Completed checkpoint 2 for job 08eb15132225903b77ee44f5ca6ad2a5 (43764 bytes in 11 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:873)**
   
   ....................
   
   **[2021-02-03 10:04:27,401] INFO Completed checkpoint 4 for job 08eb15132225903b77ee44f5ca6ad2a5 (43764 bytes in 5 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:873)**
   
   **[2021-02-03 10:04:27,401] INFO Completed checkpoint 4 for job 08eb15132225903b77ee44f5ca6ad2a5 (43764 bytes in 5 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:873)**
   
   
   
    
   
   However for 1.12.0 checkpoint cycles stuck at initial checkpoint:
   
    
   
   **[2021-02-03 10:06:24,504] INFO Triggering checkpoint 1 (type=CHECKPOINT) @ 1612339584496 for job ce255b141393a358db734db2d27ef0ea. (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:710)**
   
   
   
    
   
   As far as I see, checkpoint cycle is stuck at waiting in org.apache.flink.runtime.checkpoint.CheckpointCoordinator for coordinatorCheckpointsComplete although coordinatorsToCheckpoint is empty...
   
   
   
   
               final CompletableFuture<?> coordinatorCheckpointsComplete =
                       pendingCheckpointCompletableFuture.thenComposeAsync(
                               (pendingCheckpoint) ->
                                       OperatorCoordinatorCheckpoints
                                               .triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(
                                                       coordinatorsToCheckpoint,
                                                       pendingCheckpoint,
                                                       timer),
                               timer);
    
   
                                                                                 
   
   Simply returning from OperatorCoordinatorCheckpoints.triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion when there is no coordinatorsToCheckpoint seems to resolve the problem:
   
                                                                                
   
   **[2021-02-03 10:07:53,387] INFO Triggering checkpoint 1 (type=CHECKPOINT) @ 1612339673380 for job ffb4a06302f7e60e9325f32340d299b2. (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:710)**
   
   **[2021-02-03 10:07:53,387] INFO Triggering checkpoint 1 (type=CHECKPOINT) @ 1612339673380 for job ffb4a06302f7e60e9325f32340d299b2. (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:710)**
   
   **[2021-02-03 10:07:53,607] INFO Completed checkpoint 1 for job ffb4a06302f7e60e9325f32340d299b2 (8324 bytes in 225 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:1131)**
   
   **[2021-02-03 10:07:53,607] INFO Completed checkpoint 1 for job ffb4a06302f7e60e9325f32340d299b2 (8324 bytes in 225 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:1131)**
   
   **[2021-02-03 10:07:58,380] INFO Triggering checkpoint 2 (type=CHECKPOINT) @ 1612339678380 for job ffb4a06302f7e60e9325f32340d299b2. (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:710)**
   
   **[2021-02-03 10:07:58,380] INFO Triggering checkpoint 2 (type=CHECKPOINT) @ 1612339678380 for job ffb4a06302f7e60e9325f32340d299b2. (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:710)**
   
   **[2021-02-03 10:07:58,388] INFO Completed checkpoint 2 for job ffb4a06302f7e60e9325f32340d299b2 (8324 bytes in 7 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:1131)**
   
   **[2021-02-03 10:07:58,388] INFO Completed checkpoint 2 for job ffb4a06302f7e60e9325f32340d299b2 (8324 bytes in 7 ms). (org.apache.flink.runtime.checkpoint.CheckpointCoordinator:1131)**
   
   
   
    
   
   I have submitted this pr for this.
   
    
   
   Please help me if I am missing something or there is another solution without code change.
   
    
   
   We need to perform the upgrade and modify our jobs as soon as possible (I hope other breaking changes do not happen) so anyhelp will be appreciated..
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772331740


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit bb2701ee917f8ba4c75c14a04d8c66d388e6f908 (Fri May 28 08:17:59 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772331740


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit bb2701ee917f8ba4c75c14a04d8c66d388e6f908 (Wed Feb 03 08:33:24 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] simpleusr commented on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
simpleusr commented on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-773552189


   This ended up being an issue with jdk 1.8.0_25 which is quite old.. 
   Details can be found in
   [https://issues.apache.org/jira/browse/FLINK-21248](https://issues.apache.org/jira/browse/FLINK-21248 )
   
   Closing the pr
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] simpleusr closed pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
simpleusr closed pull request #14846:
URL: https://github.com/apache/flink/pull/14846


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] simpleusr commented on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
simpleusr commented on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772334267


   I also created below issue:
   
   https://issues.apache.org/jira/browse/FLINK-21248
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772339221


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12836",
       "triggerID" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb2701ee917f8ba4c75c14a04d8c66d388e6f908 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12836) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] simpleusr closed pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
simpleusr closed pull request #14846:
URL: https://github.com/apache/flink/pull/14846


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772339221


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb2701ee917f8ba4c75c14a04d8c66d388e6f908 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-772339221


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12836",
       "triggerID" : "bb2701ee917f8ba4c75c14a04d8c66d388e6f908",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb2701ee917f8ba4c75c14a04d8c66d388e6f908 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12836) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] simpleusr commented on pull request #14846: checkpoint problem

Posted by GitBox <gi...@apache.org>.
simpleusr commented on pull request #14846:
URL: https://github.com/apache/flink/pull/14846#issuecomment-773552189


   This ended up being an issue with jdk 1.8.0_25 which is quite old.. 
   Details can be found in
   [https://issues.apache.org/jira/browse/FLINK-21248](https://issues.apache.org/jira/browse/FLINK-21248 )
   
   Closing the pr
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org