You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/09/05 17:58:00 UTC
[jira] [Commented] (ARTEMIS-4805) Null dereferencing in ScaleDownHandler.java
[ https://issues.apache.org/jira/browse/ARTEMIS-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879652#comment-17879652 ]
ASF subversion and git services commented on ARTEMIS-4805:
----------------------------------------------------------
Commit 8b265f46252d978f19931b6b8767ba8b25e6f56d in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8b265f4625 ]
ARTEMIS-4804 & ARTEMIS-4805 mitigate NPEs in ScaleDownHandler
> Null dereferencing in ScaleDownHandler.java
> -------------------------------------------
>
> Key: ARTEMIS-4805
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4805
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Galkin Alexey
> Assignee: Justin Bertram
> Priority: Major
>
> In [line 333|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java] in file {{ScaleDownHandler.java}} variable {{queueCreateSession}} is initialized
> {code:java}
> ClientSession queueCreateSession = sessionFactory.createSession(user, password, false, true, true, false, 0);{code}
> In [line 851|https://github.com/apache/activemq-artemis/blob/main/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java] in {{ClientSessionFactoryImp.java}}, the code synchronizes with the {{sessions}} collection and checks whether the current session is closed or whether the client protocol manager is down. If the closed session or inactive client protocol manager condition is met, the session is closed and {{null}} is returned
> {code:java}
> if (closed || !clientProtocolManager.isAlive()) {
> session.close();
> return null;
> }{code}
> The {{queueCreateSession}} variable could potentially be {{null}}.
> In [line 357|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java] in file {{ScaleDownHandler.java}} variable {{queueCreateSession}} is passed to the function {{createQueueWithRoutingTypeIfNecessaryAndGetID}} as the first argument:
> {code:java}
> queueID = createQueueWithRoutingTypeIfNecessaryAndGetID(queueCreateSession, queue, message.getAddressSimpleString(), message.getRoutingType());{code}
> In [line 450|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java] in file {{ScaleDownHandler.java}} potential {{null}} dereference occurs:
> {code:java}
> session.createQueue(new QueueConfiguration(...));{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact