[jira] [Commented] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598828#comment-17598828 ] 

ASF GitHub Bot commented on HADOOP-18339:
-----------------------------------------

monthonk commented on PR #4669:
URL: https://github.com/apache/hadoop/pull/4669#issuecomment-1233981638

   @steveloughran @mukund-thakur would you be able to take a look?
   
   We also have fixing test pr https://github.com/apache/hadoop/pull/4489 related to storage class option and ready for review




> S3A storage class option only picked up when buffering writes to disk
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-18339
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18339
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.9
>            Reporter: Steve Loughran
>            Assignee: Monthon Klongklaew
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> when you switch s3a output stream buffering to heap or byte buffer, the storage class option isn't added to the put request
> {code}
>   <property>
>     <name>fs.s3a.fast.upload.buffer</name>
>     <value>bytebuffer</value>
>   </property>
> {code}
> and the ITestS3AStorageClass tests fail.
> {code}
> java.lang.AssertionError: [Storage class of object s3a://stevel-london/test/testCreateAndCopyObjectWithStorageClassGlacier/file1] 
> Expecting:
>  <null>
> to be equal to:
>  <"glacier">
> ignoring case considerations
> 	at org.apache.hadoop.fs.s3a.ITestS3AStorageClass.assertObjectHasStorageClass(ITestS3AStorageClass.java:215)
> 	at org.apache.hadoop.fs.s3a.ITestS3AStorageClass.testCreateAndCopyObjectWithStorageClassGlacier(ITestS3AStorageClass.java:129)
> {code}
> we noticed this in a code review; the request factory only sets the option when the source is a file, not memory.
> proposed: parameterize the test suite on disk/byte buffer, then fix



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org