You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by rekhajoshm <gi...@git.apache.org> on 2016/05/30 22:59:46 UTC

[GitHub] kafka pull request: KAFKA-3771; Improving Kafka core code

GitHub user rekhajoshm opened a pull request:

    https://github.com/apache/kafka/pull/1451

    KAFKA-3771; Improving Kafka core code

    - Used flatMap instead of map and flatten
    - Use isEmpty, NonEmpty, isDefined as appropriate
    - Used head, keys and keySet where appropriate
    - Used contains, diff and find where appropriate
    - Removed redundant val modifier for case class constructor
    - toString has no parameters, no side effect hence without () consistent usage
    - Removed unnecessary return , parentheses and semi colons.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rekhajoshm/kafka KAFKA-3771

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1451
    
----
commit c9a66992b1095616f87c5748f210b973ebc7eb01
Author: Rekha Joshi <re...@gmail.com>
Date:   2016-05-26T17:48:37Z

    Merge pull request #2 from apache/trunk
    
    Apache Kafka trunk pull

commit 8d7fb005cb132440e7768a5b74257d2598642e0f
Author: Rekha Joshi <re...@gmail.com>
Date:   2016-05-30T21:37:43Z

    Merge pull request #3 from apache/trunk
    
    Apache Kafka trunk pull

commit 7b3273de9d7310695701bd2407992d6c69517f47
Author: Joshi <re...@gmail.com>
Date:   2016-05-30T23:00:58Z

    KAFKA-3771; Improving Kafka core code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1451: KAFKA-3771; Improving Kafka core code

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1451


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---