[GitHub] [flink] matriv commented on a change in pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`

[GitBox <gi...@apache.org>]

matriv commented on a change in pull request #19249:
URL: https://github.com/apache/flink/pull/19249#discussion_r837673114



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##########
@@ -204,25 +205,39 @@ TestSpec testResult(
             return this;
         }
 
-        private Executable createTestItemExecutable(TestItem testItem) {
+        private Executable createTestItemExecutable(
+                TestItem testItem, boolean stateBackendChangelogEnabled) {
             return () -> {
+                Configuration conf = new Configuration();
+                conf.set(
+                        StateChangelogOptions.ENABLE_STATE_CHANGE_LOG,
+                        stateBackendChangelogEnabled);

Review comment:
       Thank you!, pushed the change.
   Indeed without the fix, when `rocksdb` is used it fails with NPE during `StringData` serialization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org