You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2002/09/26 06:30:25 UTC
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Why did you principally credit Sander van Zoest for submitting the
patch of Michael Radwin <radwin_at_yahoo-inc.com> ?
Bill
At 06:22 PM 9/25/2002, dirkx@apache.org wrote:
>dirkx 2002/09/25 16:22:34
>
> Modified: src CHANGES
> src/modules/standard mod_headers.c
> Log:
> Scratch another its - this patchs allows me to hugely simply auth modules
> which use non 4xx methods for auth (such as cookies, referers ,etc).
>
> Submitted by Sander van Zoest (for a slightly different reason) - see
> explanation below.
>
> From: Sander van Zoest
> To: dev@httpd.apache.org
>
> It is common practice to set Cookie's to pass along on HTTP
> redirects for "login" authentication.
>
> When implementing P3P <http://www.w3.org/P3P/> using
> mod_headers.c the Header directive only sets r->headers_out
> and does not pass the headers along for non-2XX responses
> such as error pages and redirects.
>
> To provide this functionality we added the ErrorHeader
> directive which populates r->err_headers_out instead.
>
> Below follows a patch for 1.3.X by Michael Radwin <radwin_at_yahoo-inc.com>.
>
> I have some code that attempts to add Directive to 2.0.X, but
> it seems that output_filters are shortcuted on 3XX responses.
> While now by setting the Header directive it also passes the headers
> along at for all non-2XX responses except 3XX responses.
>
> Cheers,
>
> --
> Sander van Zoest
>
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by Sander van Zoest <sa...@yahoo-inc.com>.
On Thu, Sep 26, 2002 at 10:22:11AM -0700, Aaron Bannert wrote:
> On Thu, Sep 26, 2002 at 07:51:42AM -0500, William A. Rowe, Jr. wrote:
> > Hmmm. If it was written by Michael, I'd think;
> Was it?
Yes. Michael Radwin wrote the code.
I wanted to make sure he got credit for that.
After talking to Michael about submitting it.
I just double checked that it would work on HEAD and
submitted it, since he didn't have the time for that.
Sorry for the confusion.
--
Sander van Zoest +1 (619) 881-3000
Yahoo!, Inc. sander@yahoo-inc.com
<http://www.yahoo.com/> <http://sander.vanzoest.com/>
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by Aaron Bannert <aa...@clove.org>.
On Thu, Sep 26, 2002 at 07:51:42AM -0500, William A. Rowe, Jr. wrote:
> Hmmm. If it was written by Michael, I'd think;
Was it?
-aaron
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 03:03 AM 9/26/2002, Dirk-Willem van Gulik wrote:
>On Wed, 25 Sep 2002, William A. Rowe, Jr. wrote:
>
>> Why did you principally credit Sander van Zoest for submitting the
>> patch of Michael Radwin <radwin_at_yahoo-inc.com> ?
>
>Darn - not intentionally - I wanted to separate who wrote it and who
>actually submitted it to the ASF into the (bug db) - i.e. there it said
>that SvZ put it in the DB - did I mix it up ? Did Michael put it there ?
>
>So is this now wrong:
>
> PR: 9181
> Obtained from: Michael Radwin
> Submitted by: Sander van Zoest
Hmmm. If it was written by Michael, I'd think;
Submitted by: Michael Radwin
Reviewed by: Sander van Zoest, Dirk-Willem van Gulik
Obtained from: correspondence to Sander van Zoest
Obtained from implies a place [to me.] E.g. bug #4444, or
dev@httpd message id: foo<aaaa>
Bill
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 03:03 AM 9/26/2002, Dirk-Willem van Gulik wrote:
>On Wed, 25 Sep 2002, William A. Rowe, Jr. wrote:
>
>> Why did you principally credit Sander van Zoest for submitting the
>> patch of Michael Radwin <radwin_at_yahoo-inc.com> ?
>
>Darn - not intentionally - I wanted to separate who wrote it and who
>actually submitted it to the ASF into the (bug db) - i.e. there it said
>that SvZ put it in the DB - did I mix it up ? Did Michael put it there ?
>
>So is this now wrong:
>
> PR: 9181
> Obtained from: Michael Radwin
> Submitted by: Sander van Zoest
Hmmm. If it was written by Michael, I'd think;
Submitted by: Michael Radwin
Reviewed by: Sander van Zoest, Dirk-Willem van Gulik
Obtained from: correspondence to Sander van Zoest
Obtained from implies a place [to me.] E.g. bug #4444, or
dev@httpd message id: foo<aaaa>
Bill
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by Dirk-Willem van Gulik <di...@webweaving.org>.
On Wed, 25 Sep 2002, William A. Rowe, Jr. wrote:
> Why did you principally credit Sander van Zoest for submitting the
> patch of Michael Radwin <radwin_at_yahoo-inc.com> ?
Darn - not intentionally - I wanted to separate who wrote it and who
actually submitted it to the ASF into the (bug db) - i.e. there it said
that SvZ put it in the DB - did I mix it up ? Did Michael put it there ?
So is this now wrong:
PR: 9181
Obtained from: Michael Radwin
Submitted by: Sander van Zoest
DW
Re: cvs commit: apache-1.3/src/modules/standard mod_headers.c
Posted by Dirk-Willem van Gulik <di...@webweaving.org>.
On Wed, 25 Sep 2002, William A. Rowe, Jr. wrote:
> Why did you principally credit Sander van Zoest for submitting the
> patch of Michael Radwin <radwin_at_yahoo-inc.com> ?
Darn - not intentionally - I wanted to separate who wrote it and who
actually submitted it to the ASF into the (bug db) - i.e. there it said
that SvZ put it in the DB - did I mix it up ? Did Michael put it there ?
So is this now wrong:
PR: 9181
Obtained from: Michael Radwin
Submitted by: Sander van Zoest
DW