You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/21 05:41:11 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6038: Fix some mistakes in the comments

wu-sheng commented on a change in pull request #6038:
URL: https://github.com/apache/skywalking/pull/6038#discussion_r546518761



##########
File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/v4/define/AbstractControllerInstrumentation.java
##########
@@ -26,6 +26,7 @@
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassAnnotationMatch;
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
 import org.apache.skywalking.apm.plugin.spring.mvc.commons.Constants;
+import org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.RequestMappingMethodInterceptor;

Review comment:
       Please run the maven check locally, comments related thing should not be in import.
   Same as below.
   That is why CI fails.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org