You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Earwin Burrfoot (JIRA)" <ji...@apache.org> on 2009/06/03 21:57:07 UTC
[jira] Created: (LUCENE-1677) Remove GCJ IndexReader
specializations
Remove GCJ IndexReader specializations
--------------------------------------
Key: LUCENE-1677
URL: https://issues.apache.org/jira/browse/LUCENE-1677
Project: Lucene - Java
Issue Type: Task
Reporter: Earwin Burrfoot
Fix For: 2.9
These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719265#action_12719265 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
bq. Is there a reason why test-tag does not depend on compile-tag? Previously, I could just run "ant test-tag" and it downloaded the tag, compiled it and run the tests. Now I need to run "ant compile-tag test-tag".
Ugh, my bad. I'll fix...
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719422#action_12719422 ]
Shai Erera commented on LUCENE-1677:
------------------------------------
I think test-core is broken too ...
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723378#action_12723378 ]
Earwin Burrfoot commented on LUCENE-1677:
-----------------------------------------
I thought we're doing everything right now as it is broken already.
And I have a half-written patch with SR cleanup after GCJ removal :)
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1677.
----------------------------------------
Resolution: Fixed
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723785#action_12723785 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
I'll remove src/gcj in a day or two...
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723376#action_12723376 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
I thought so? Ie deprecate now & remove in 3.0?
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721410#action_12721410 ]
Hoss Man commented on LUCENE-1677:
----------------------------------
{quote}
I did ask:
http://www.mail-archive.com/java-user@lucene.apache.org/msg26726.html
And nobody answered.
So I think we should remove it, and the org.apache.lucene.SegmentReader.class system property? Can you post a patch? Thanks.
{quote}
FWIW: Google code search pops up a few uses in publicly available code...
http://www.google.co.uk/codesearch?hl=en&lr=&q=org.apache.lucene.SegmentReader.class+-package%3Arepos%2Fasf%2Flucene%2Fjava&sbtn=Search
What jumps out at me is that apparently older versions of Compass relied on this feature ... it looks like Compass 2.0 eliminated the need for this class, but i just wanted to point this out.
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Earwin Burrfoot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723355#action_12723355 ]
Earwin Burrfoot commented on LUCENE-1677:
-----------------------------------------
Mike, are we going to postpone actual deletion of these classes for 3.0?
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716428#action_12716428 ]
Otis Gospodnetic commented on LUCENE-1677:
------------------------------------------
In my cca 10 year history of being around Lucene I think I saw GCJ mentioned only about half a dozen times.
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1677.
----------------------------------------
Resolution: Fixed
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reopened LUCENE-1677:
----------------------------------------
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717740#action_12717740 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
bq. Mike, you said you are going to ask people on java-user, anybody replied that they need it?
I did ask:
http://www.mail-archive.com/java-user@lucene.apache.org/msg26726.html
And nobody answered.
So I think we should remove it, and the org.apache.lucene.SegmentReader.class system property? Can you post a patch? Thanks.
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719504#action_12719504 ]
Shai Erera commented on LUCENE-1677:
------------------------------------
You're right. I updated build.xml, but the change for test-core was actually in common-build.xml. sorry for the false alarm.
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719253#action_12719253 ]
Shai Erera commented on LUCENE-1677:
------------------------------------
Is there a reason why test-tag does not depend on compile-tag? Previously, I could just run "ant test-tag" and it downloaded the tag, compiled it and run the tests. Now I need to run "ant compile-tag test-tag".
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1677:
------------------------------------------
Assignee: Michael McCandless
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769787#action_12769787 ]
Uwe Schindler commented on LUCENE-1677:
---------------------------------------
Removed the SegmentReader system property in Lucene 3.0
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719491#action_12719491 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
bq. I think test-core is broken too ...
It should be fixed now? (I reverted it).
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1677) Remove GCJ IndexReader
specializations
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723784#action_12723784 ]
Michael McCandless commented on LUCENE-1677:
--------------------------------------------
OK, since they are broken already anyway, let's remove them now? But, I think we should wait until 3.0 to remove respecting the org.apache.lucene.SegmentReader.class property.
> Remove GCJ IndexReader specializations
> --------------------------------------
>
> Key: LUCENE-1677
> URL: https://issues.apache.org/jira/browse/LUCENE-1677
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9
>
>
> These specializations are outdated, unsupported, most probably pointless due to the speed of modern JVMs and, I bet, nobody uses them (Mike, you said you are going to ask people on java-user, anybody replied that they need it?). While giving nothing, they make SegmentReader instantiation code look real ugly.
> If nobody objects, I'm going to post a patch that removes these from Lucene.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org