[GitHub] michaelandrepearce removed a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

[GitBox <gi...@apache.org>]

michaelandrepearce removed a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-460706195
 
 
   -1 (and im sorry, feature was added for a very specific requirement, after a number of issues with broker lockups, where simply failing to slave could have saved day), critical analyzer was implemented specifically to pick up locking issues (such as deadlock and live locks), disk and other issues with something not running  as performantly as expected), that are on critical path, and if found, kill the broker so it would fail over to slave.
   
   Solution should be to remove or improve the locking, or improve performance in this area. (or even increase critical timeout in your system)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services