You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/01 15:10:31 UTC
[PR] ci: select each lane on inputs that can change its verdict [maka]
Astro-Han opened a new pull request, #4482:
URL: https://github.com/apache/maka/pull/4482
Three lanes were allocating runners for inputs that could not change their verdict. Each commit reverts independently. Measurements are replays of `planTests()` and of each workflow's `paths:` globs over the last 300 `--first-parent` commits, from the survey in #4480.
Nothing here touches `test`, its name, its triggers, or `.asf.yaml`.
### 1. Four path buckets fell through the planner into `--full`
`native/`, `patches/`, `.asf.yaml` and `deny.toml` had no classifier branch in `planTests`, so each reached the unknown-path guard and forced every surface. **That was 22 of the 57 full-suite selections over 300 commits — more than `package-lock.json` (11) or `.github/workflows/ci.yml` (14).**
Each bucket already had an owner:
- **`native/gitoxide-helper/`** — `gitoxide-helper-admission` runs `cargo fmt`, `cargo test`, and the JavaScript invocation contract on three operating systems. No step in `ci.yml` reads it.
- **`native/runtime-host-peer/` and `deny.toml`** — `release:cli:pack` builds this addon into the tarball and runs `cargo deny` against that policy, so `isCliPackagePath` names them now. Lint, typecheck, Storybook and a real window have no stake.
- **`patches/`** — the sharpest case. `isAsfSourcePath` and `isCliPackagePath` both name `patches/` and **neither could ever run**, because the classifier sent those files to the full suite before either predicate was reached. The existing ASF-source assertion was passing for the wrong reason.
- **`.asf.yaml`** — branch protection configuration. `ci-workflow-policy.test.mjs` reads it and runs unconditionally in the install-free block, so its gate has already run by the time a plan is consumed.
The unknown-path guard is untouched and still fails safe; there is a test for that.
Replayed over the same 300 commits:
| surface | before | after |
|---|---|---|
| `full` | 19.0% | **11.7%** |
| `appIcons` | 21.3% | **14.0%** |
| `asfSource` | 19.7% | **13.7%** |
| `stateRootCompat` | 28.7% | **21.7%** |
| `e2e` | 57.7% | 54.0% |
| `storybook` | 52.0% | 46.3% |
| `astryxSurface` | 48.0% | 42.3% |
| mean workspaces selected | 5.36 / 10 | **4.86 / 10** |
| commits selecting all 10 | 109 | **87** |
### 2. `cli-package-validation` had a concurrency group but no `cancel-in-progress`
That is the setting which makes a group cancel rather than queue. Without it a run that a newer push had already invalidated was not cancelled — it ran to completion at full price while its replacement waited behind it in the same group.
It fans out to ~14 jobs per run across four build targets and four install environments, which makes it **the largest holder of runner slots in the repository: 736 jobs against CI's 523** over one measured day. In that window **14 of its 60 pull request runs were superseded while still executing, spending 275 of 1672 slot-minutes on work that was already obsolete.** Only 5 runs were cancelled, against 76 for CI, which does set this.
Scoped to `pull_request` exactly the way `ci.yml` scopes its own group: release callers arrive through `workflow_call`, where `github.event_name` belongs to the caller, so a publication run is never cancelled.
### 3. `gitoxide-helper-admission` selected on a manifest it does not read
`packages/runtime/package.json` has been in that filter since #3561, where it stood for a source-import dependency. **That dependency is gone — `packages/runtime` contains no Gitoxide reference of any kind**, and every source the lane reads is already named directly.
It was the lane's dominant trigger anyway: **12 of 16 selections across 300 commits**. Workspace manifest diffs are dominated by `"version"` and npm script edits (41 and >150 occurrences respectively over those commits), so each one spent three runners — `ubuntu-latest`, `macos-latest`, `windows-latest` — building and testing a Rust crate whose inputs had not moved. After the change the lane selects **4 of 300 instead of 16**.
**Given up:** the indirect case where `packages/runtime`'s build script changes what `npm --workspace @maka/runtime run build` produces here. That was never covered consistently — this job builds four workspaces and only one of their manifests was listed — and `npm run build` under the `code` surface, which selects on 94.7% of commits, reaches all four before this lane would.
### What each change costs
| | budget | given up |
|---|---|---|
| 1 | minutes inside one slot | Rust and branch-protection changes stop dragging Storybook, e2e, app-icon drift and all 10 workspace suites. The lanes that own them are unchanged, but none of those lanes is a required context — see the note below. |
| 2 | runner slots | nothing on pull requests |
| 3 | runner slots (3 runners × ~1.5 min per selection) | above |
**One thing worth a maintainer's eye:** `test` is the only entry in `.asf.yaml`'s `required_status_checks.contexts`. Every lane named here — `gitoxide-helper-admission`, `cli-package-validation`, `release-windows-check`, `windows-recovery` — runs on pull requests but cannot block a merge. Change 1 relies on those lanes for Rust coverage, which is the same reliance the repository already has; it does not add to it, but it does make it load-bearing in a place it was previously masked by the full-suite fallback. Say the word if that trade should be made differently.
### Verification
`node --test --test-concurrency=1 scripts/ci-test-plan.test.mjs scripts/ci-workflow-policy.test.mjs scripts/verify-windows-harness.test.mjs` — 111 pass, 0 fail. Seven new assertions, written failing first.
No repo-wide build or test suite was run locally, and no workflow was dispatched.
Refs #4480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] ci: give the full-suite fallback's biggest buckets their real owners [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #4482:
URL: https://github.com/apache/maka/pull/4482#issuecomment-5497569168
Correction to my requested-fix wording: retaining the core full fallback alone is not sufficient, because core `npm run build` does not build `native/gitoxide-helper`, and Runtime Host `test:dist` is only Node tests. The dedicated admission workflow is the only current place that runs `cargo fmt --check`, `cargo test --locked`, and the real Rust-binary invocation contract.
The blocking invariant is therefore: when the *complete* PR/main diff changes `native/gitoxide-helper/**`, at least one mandatory path must run the helper cargo test (and ideally the invocation contract). Preserve CI reduction by making that decision from a complete-diff planner, not GitHub `paths:`. A small always-scheduled planner may decide whether to fan out the three-platform Rust jobs; or the unconditional core `test` can conditionally run a Linux helper qualification as the fail-safe while the filtered three-platform lane remains best-effort. The latter duplicates Linux work only on actual helper changes, never on unrelated PRs. My Request changes conclusion remains unchanged; this supersedes the earlier proposed implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] ci: give the full-suite fallback's biggest buckets their real owners [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #4482:
URL: https://github.com/apache/maka/pull/4482#issuecomment-5497571684
Rewritten against all three findings, and rebased onto main now that #4483 has landed. @M4n5ter @me2seeks — ready for another look.
**1. `.asf.yaml` was routed away from its own test.** Confirmed and fixed at the owner. It now goes to `RELEASE_CONTRACT_FILES`, so it selects `product-release.test.mjs` — the suite that actually parses it. My original claim that `ci-workflow-policy.test.mjs` covered it was wrong: that file only mentions `.asf.yaml` in a comment. The false reason appeared in three places and all three are gone.
**2. `patches/` keeps the fail-safe full path.** Your evidence decided this. The node-pty patch is regressed by `packages/runtime/src/__tests__/node-pty-write-lifecycle.test.ts`, while the packaging smoke a build-shaped selection would run only asserts the method name still appears in the tarball (`smoke-release-cli-package.mjs:412`). Narrowing this needs an explicit patch-to-consumer map; the test now says so and asserts `full`.
**3. `native/` is enumerated, not prefixed.** `native/gitoxide-helper/` and `native/runtime-host-peer/` by name, with a regression proving an unowned native root still selects full. What earns the exemption is having a lane, not being written in Rust.
**Non-blocking simplification: agreed, and deleted.** You were right that it skipped every entry and proved nothing. Rather than restate the reachability check, it is replaced by the invariant this change actually needs: any lane filtering both `pull_request` and `push` must filter them on the same paths. That immediately caught a pre-existing drift in `dependency-audit.yml`, whose `push` list omitted its own workflow file — corrected here. Verified red for an entry added, removed, or renamed on either side. `windows-recovery.yml` deliberately leaves `push` unfiltered, so the rule only applies when both sides filter, and the comment records why.
**One thing you did not raise, which I got wrong myself.** Commit 3's rationale was backwards. The coupling is real and still exists — `gitoxide-helper-invocation-internal.ts` imports `@maka/runtime/child-process-lifecycle`, resolvable only through that manifest's exports map. What changed is who covers it: a change to `packages/runtime/package.json` selects `packages/runtime-host` through the reverse dependency closure, so core CI typechecks and tests that import on the required context regardless. Verified by replaying `planTests`. The commit message and PR body now say that instead.
All replay figures were recomputed after `patches/` moved back — `full` 19.3% → 13.3%, mean workspaces 5.34 → 4.96, the gitoxide lane 17 → 5 of 300. 114 install-free tests pass.
Note the `test` check here will stay red until #4492 lands: #4460 added a workflow on `ubuntu-latest` 35 minutes before #4483 banned that label, so main is currently red for a reason unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] ci: give the full-suite fallback's biggest buckets their real owners [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4482:
URL: https://github.com/apache/maka/pull/4482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] ci: give the full-suite fallback's biggest buckets their real owners [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #4482:
URL: https://github.com/apache/maka/pull/4482#issuecomment-5497620192
Exact-head follow-up: this branch currently fails its own install-free CI policy suite, so it cannot be approved yet. On `ea30b76083271cf5756db7e52b520c9a68f3f123`, `node --test --test-concurrency=1 scripts/ci-test-plan.test.mjs scripts/ci-workflow-policy.test.mjs scripts/verify-windows-harness.test.mjs` reports 114 pass / 1 fail. The failure is `no lane asks for the one runner label that queues`: `.github/workflows/model-metadata-upkeep.yml` now contains `runs-on: ubuntu-latest`.
This is a real current-base integration issue, not a local dependency failure. Pin that workflow to `ubuntu-24.04` (or rebuild this PR on current main with the corresponding runner-pin change), then rerun the suite. Once that is green, the CI-reduction scope is acceptable and I will approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org