You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/19 13:40:29 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

ppalaga opened a new pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018#issuecomment-731094769


   @jamesnetherton could you please re-review?
   
   * The Quarkus plugin's generate-code mojo commit has a fix for the Heisenbug
   * New protobuf commit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018#issuecomment-731098283


   > @jamesnetherton could you please re-review?
   > 
   > * The Quarkus plugin's generate-code mojo commit has a fix for the Heisenbug
   > * New protobuf commit
   
   Looks good to me :+1: 
   
   Should we perhaps drop a note into our gRPC docs to point users at `quarkus-maven-plugin` to do the proto class generation? The camel component docs reference `org.xolstice.maven.plugins:protobuf-maven-plugin`, which is maybe not desirable here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018#issuecomment-731145533


   The messaging failure does not seem to be related.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2018: Leverage Quarkus plugin's generate-code mojo instead of protobuf-maven-plugin to generate protobuf stubs

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2018:
URL: https://github.com/apache/camel-quarkus/pull/2018#issuecomment-731100003


   > Should we perhaps drop a note into our gRPC docs to point users at `quarkus-maven-plugin`
   
   Of course, I even had it in one of my revisions and I wonder why it disappeared. Thanks for noticing! Let me find it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org