You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "paul cannon (Created) (JIRA)" <ji...@apache.org> on 2011/11/04 20:39:51 UTC
[jira] [Created] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Make cqlsh look for a suitable python version
---------------------------------------------
Key: CASSANDRA-3457
URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
Project: Cassandra
Issue Type: Bug
Components: Tools
Reporter: paul cannon
Assignee: paul cannon
Priority: Minor
On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "paul cannon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
paul cannon updated CASSANDRA-3457:
-----------------------------------
Attachment: 3457.patch.txt
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158640#comment-13158640 ]
paul cannon commented on CASSANDRA-3457:
----------------------------------------
bq. Why that particular ordering?
No strong reason. 2.6 is just a little more likely to be found than 2.7, over our expected set of install targets, and both 2.6 and 2.7 are little bits faster than 2.5.
Fine with changing to something else.
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.0.3
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cqlsh
> Fix For: 1.0.5
>
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "T Jake Luciani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158650#comment-13158650 ]
T Jake Luciani commented on CASSANDRA-3457:
-------------------------------------------
tested +1
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.0.3
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cqlsh
> Fix For: 1.0.5
>
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158621#comment-13158621 ]
Jonathan Ellis commented on CASSANDRA-3457:
-------------------------------------------
{noformat}
for pyver in 2.6 2.7 2.5
{noformat}
Why that particular ordering?
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.0.3
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cqlsh
> Fix For: 1.0.5
>
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158659#comment-13158659 ]
paul cannon commented on CASSANDRA-3457:
----------------------------------------
One minor edit: if we change the shebang from {{\#\!/bin/bash}} to {{\#\!/bin/sh}}, it will work for Solaris too. none of the code actually needs bash.
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.0.3
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cqlsh
> Fix For: 1.0.5
>
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3457) Make cqlsh look for a suitable
python version
Posted by "paul cannon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152154#comment-13152154 ]
paul cannon commented on CASSANDRA-3457:
----------------------------------------
Just a note for future reference- the opinion has been expressed that requiring EPEL for cassandra rpms may not be an option. Might need to remove the 2.5 features from cqlsh and test it along with the python driver on 2.4.
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3457) Make cqlsh look for
a suitable python version
Posted by "T Jake Luciani (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158650#comment-13158650 ]
T Jake Luciani edited comment on CASSANDRA-3457 at 11/28/11 7:15 PM:
---------------------------------------------------------------------
tested on centos 6 which used 2.4 by default, with this patch it finds the right version so +1
was (Author: tjake):
tested +1
> Make cqlsh look for a suitable python version
> ---------------------------------------------
>
> Key: CASSANDRA-3457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3457
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.0.3
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cqlsh
> Fix For: 1.0.5
>
> Attachments: 3457.patch.txt
>
>
> On RHEL 5, which I guess we still want to support, the default "python" in the path is still 2.4. cqlsh does use a fair number of python features introduced in 2.5, like collections.defaultdict, functools.partial, generators. We can require RHEL 5 users to install a later python from EPEL, but we'd have to call it as 'python2.5', or 'python2.6', etc.
> So rather than take the time to vet everything against python2.4, we may want to make a wrapper script for cqlsh that checks for the existence of python2.7, 2.6, and 2.5, and calls the appropriate one to run the real cqlsh.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira