[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

[sethah <gi...@git.apache.org>]

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11119#discussion_r88724978
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala ---
    @@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}
     import org.apache.spark.sql.types.{IntegerType, StructType}
     
     /**
    - * Common params for KMeans and KMeansModel
    + * Params for KMeans
    + */
    +
    +private[clustering] trait KMeansInitialModelParams extends HasInitialModel[KMeansModel] {
    +  /**
    +   * Param for KMeansModel to use for warm start.
    +   * Whenever initialModel is set:
    +   *   1. the initialModel k will override the param k;
    +   *   2. the param initMode is set to initialModel and manually set is ignored;
    --- End diff --
    
    2. the param initMode is set to "initialModel" and manually setting initMode will be ignored
    
    nit: Let's just remove the punctuation from the numbered list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org