[jira] [Updated] (SOLR-5230) Call DelegatingCollector.finish() during grouping

["Erik Hatcher (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher updated SOLR-5230:
-------------------------------

    Attachment: SOLR-5230.patch

Here's a 4x branch patch that includes a test case.  The test case fails without the Grouping.java changes and passes after.

Ok to commit?  I'll do this in the next day or so if no objections.

A more general purpose mocking test would be useful too, but this test at least covers the case of the collapse query parser breaking grouping.

> Call DelegatingCollector.finish() during grouping
> -------------------------------------------------
>
>                 Key: SOLR-5230
>                 URL: https://issues.apache.org/jira/browse/SOLR-5230
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.4
>            Reporter: Joel Bernstein
>            Priority: Minor
>             Fix For: 4.7
>
>         Attachments: SOLR-5230.patch, SOLR-5230.patch
>
>
> This is an add-on to SOLR-5020 to call the new DelegatingCollector.finish() method from inside the grouping flow. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org