You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/08/07 19:46:59 UTC
svn commit: r1616556 -
/commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java
Author: sebb
Date: Thu Aug 7 17:46:58 2014
New Revision: 1616556
URL: http://svn.apache.org/r1616556
Log:
Only create String once
Modified:
commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java
Modified: commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java?rev=1616556&r1=1616555&r2=1616556&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java (original)
+++ commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientExample.java Thu Aug 7 17:46:58 2014
@@ -137,7 +137,8 @@ public class TelnetClientExample impleme
ret_read = System.in.read(buff);
if(ret_read > 0)
{
- if((new String(buff, 0, ret_read)).startsWith("AYT"))
+ final String line = new String(buff, 0, ret_read); // deliberate use of default charset
+ if(line.startsWith("AYT"))
{
try
{
@@ -150,14 +151,14 @@ public class TelnetClientExample impleme
System.err.println("Exception waiting AYT response: " + e.getMessage());
}
}
- else if((new String(buff, 0, ret_read)).startsWith("OPT"))
+ else if(line.startsWith("OPT"))
{
System.out.println("Status of options:");
for(int ii=0; ii<25; ii++) {
System.out.println("Local Option " + ii + ":" + tc.getLocalOptionState(ii) + " Remote Option " + ii + ":" + tc.getRemoteOptionState(ii));
}
}
- else if((new String(buff, 0, ret_read)).startsWith("REGISTER"))
+ else if(line.startsWith("REGISTER"))
{
StringTokenizer st = new StringTokenizer(new String(buff));
try
@@ -187,7 +188,7 @@ public class TelnetClientExample impleme
}
}
}
- else if((new String(buff, 0, ret_read)).startsWith("UNREGISTER"))
+ else if(line.startsWith("UNREGISTER"))
{
StringTokenizer st = new StringTokenizer(new String(buff));
try
@@ -210,15 +211,15 @@ public class TelnetClientExample impleme
}
}
}
- else if((new String(buff, 0, ret_read)).startsWith("SPY"))
+ else if(line.startsWith("SPY"))
{
tc.registerSpyStream(fout);
}
- else if((new String(buff, 0, ret_read)).startsWith("UNSPY"))
+ else if(line.startsWith("UNSPY"))
{
tc.stopSpyStream();
}
- else if((new String(buff, 0, ret_read)).matches("^\\^[A-Z^]\\r?\\n?$"))
+ else if(line.matches("^\\^[A-Z^]\\r?\\n?$"))
{
byte toSend = buff[1];
if (toSend == '^') {