Re: [PR] AVRO-4271: [ruby] Use json instead of multi_json [avro]

["hmcguire-shopify (via GitHub)" <gi...@apache.org>]

hmcguire-shopify commented on code in PR #3825:
URL: https://github.com/apache/avro/pull/3825#discussion_r3815140351


##########
lang/ruby/lib/avro/protocol.rb:
##########
@@ -23,7 +23,7 @@ class ProtocolParseError < Avro::AvroError; end
 
     attr_reader :name, :namespace, :types, :messages, :md5, :doc
     def self.parse(protocol_string)
-      json_data = MultiJson.load(protocol_string)
+      json_data = JSON.parse(protocol_string, create_additions: false, quirks_mode: true)

Review Comment:
   These arguments will need to be updated in preparation for `json` gem 3.0: https://github.com/sferik/multi_json/pull/67



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org