[GitHub] arina-ielchiieva commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r234524071
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
 ##########
 @@ -442,6 +467,14 @@ public void run() {
       // StatusThread is started
       final Controller controller = dContext.getController();
       final DrillbitEndpoint localBitEndPoint = dContext.getEndpoint();
+      try {
+        pollShutdown(drillbit);
+      } catch (IOException e) {
+        e.printStackTrace();
 
 Review comment:
   I think we should not use `e.printStackTrace();` but rather do proper error handling or logging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services