You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/21 13:21:47 UTC
Review Request 38552: [2/2]CMake: Add Windows-specific build targets
for APR.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3383
https://issues.apache.org/jira/browse/MESOS-3383
Repository: mesos
Description
-------
APR is required for Mesos to run. Normally we expect that a user has
obtained APR with their favorite package manager, but on Windows, we
cannot really expect that this is the case. So, we have to rope in the
dependency manually in the CMake build system.
This commit will introduce the necessary build targets to obtain,
configure, build, and install APR for Windows builds. It will ignore APR
and assume it's there for Linux builds.
Diffs
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
Diff: https://reviews.apache.org/r/38552/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38552: [2/2]CMake: Add Windows-specific build
targets for APR.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/#review100740
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 21, 2015, 11:21 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38552/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 11:21 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> APR is required for Mesos to run. Normally we expect that a user has
> obtained APR with their favorite package manager, but on Windows, we
> cannot really expect that this is the case. So, we have to rope in the
> dependency manually in the CMake build system.
>
> This commit will introduce the necessary build targets to obtain,
> configure, build, and install APR for Windows builds. It will ignore APR
> and assume it's there for Linux builds.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38552/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38552: [2/2]CMake: Add Windows-specific build
targets for APR.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/#review99802
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 21, 2015, 4:21 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38552/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 4:21 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> APR is required for Mesos to run. Normally we expect that a user has
> obtained APR with their favorite package manager, but on Windows, we
> cannot really expect that this is the case. So, we have to rope in the
> dependency manually in the CMake build system.
>
> This commit will introduce the necessary build targets to obtain,
> configure, build, and install APR for Windows builds. It will ignore APR
> and assume it's there for Linux builds.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38552/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38552: [2/2]CMake: Add Windows-specific build
targets for APR.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/#review100612
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 21, 2015, 4:21 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38552/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 4:21 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> APR is required for Mesos to run. Normally we expect that a user has
> obtained APR with their favorite package manager, but on Windows, we
> cannot really expect that this is the case. So, we have to rope in the
> dependency manually in the CMake build system.
>
> This commit will introduce the necessary build targets to obtain,
> configure, build, and install APR for Windows builds. It will ignore APR
> and assume it's there for Linux builds.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38552/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38552: [2/2]CMake: Add Windows-specific build
targets for APR.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/#review99746
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 38541, 38542, 38549, 38550, 38551, 38552]
All tests passed.
- Mesos ReviewBot
On Sept. 21, 2015, 11:21 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38552/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 11:21 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3383
> https://issues.apache.org/jira/browse/MESOS-3383
>
>
> Repository: mesos
>
>
> Description
> -------
>
> APR is required for Mesos to run. Normally we expect that a user has
> obtained APR with their favorite package manager, but on Windows, we
> cannot really expect that this is the case. So, we have to rope in the
> dependency manually in the CMake build system.
>
> This commit will introduce the necessary build targets to obtain,
> configure, build, and install APR for Windows builds. It will ignore APR
> and assume it's there for Linux builds.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
>
> Diff: https://reviews.apache.org/r/38552/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38552: [2/2]CMake: Add Windows-specific build
targets for APR.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38552/
-----------------------------------------------------------
(Updated Sept. 26, 2015, 10:05 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3383
https://issues.apache.org/jira/browse/MESOS-3383
Repository: mesos
Description
-------
APR is required for Mesos to run. Normally we expect that a user has
obtained APR with their favorite package manager, but on Windows, we
cannot really expect that this is the case. So, we have to rope in the
dependency manually in the CMake build system.
This commit will introduce the necessary build targets to obtain,
configure, build, and install APR for Windows builds. It will ignore APR
and assume it's there for Linux builds.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d
3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423
Diff: https://reviews.apache.org/r/38552/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer