You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/03/09 16:08:26 UTC

[PR] Test Netty 4.2.0.RC4 [pekko]

pjfanning opened a new pull request, #1794:
URL: https://github.com/apache/pekko/pull/1794

   Not for merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.Final [pekko]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2803761694

   > @ferenc-csaky wdyt , we plan to upgrade to netty 4.2.0.final in next version, Will flink upgrade to Netty 4.2.x too?
   
   Sorry for the late answer, AFAIK there is no push ATM to do that. Although IMO the Flink dependency should probably not be a blocker for this on the Pekko side. Requiring the Netty upgrade might drive the project a bit to do that sooner than later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] upgrade to Netty 4.2.0.Final [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1794:
URL: https://github.com/apache/pekko/pull/1794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.Final [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2781379857

   @pjfanning Yes, we need some abstraction to do that, currently, it's bound to NioSocket, the Netty 4.2 is pretty cool about separate the iohandler with eventloop, I think that can be done more elegantly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.Final [pekko]

Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2781369533

   I agree. Just upgrading the dependency is definitely enough for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2719214435

   I wouldn't delay the 1.2.0 release for this but if 4.2.0 final release is made before we make the 1.2.0 final release then I think we should upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2709306247

   Yes, in Netty 4.2, the IOHandler is seperated with the EventLoop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.Final [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2781312080

   @ferenc-csaky wdyt , we plan to upgrade to netty 4.2.0.final in next version, Will flink upgrade to Netty 4.2.x too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.Final [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2781344348

   @He-Pin @mkurz I had a quick look at Pekko code and it doesn't immediately look like we use the Netty abstractions that now support io_uring. I may have missed something. I would prefer to do any uptake of Netty 4.2 specific features in a later PR. Still, it's interesting to consider if there is something that we could support via a config option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2708979445

   Our build fails if we use any deprecated code and Netty's NioEventLoopGroup is now deprecated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2758696942

   > I wouldn't delay the 1.2.0 release for this but if 4.2.0 final release is made before we make the 1.2.0 final release then I think we should upgrade.
   
   +1 for upgrading to Netty 4.2 in Pekko 1.2.0 already (I guess Pekko 2.0 is far away still, so IMHO upgrading now would be much better). Should not do any harm, [according to their release notes](https://netty.io/news/2025/03/07/4-2-0-RC4.html):
   
   > Everyone using netty 4.1.x should be able to upgrade to 4.2.0.RC4 without any API breakage. The only new requirement is JDK8 or later.
   
   We will upgrade in Play as soon as 4.2 is out (and adding the new io_uring native transport):
   - https://github.com/playframework/playframework/pull/13200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2716271267

   I think we should schedule this to 2.0.x and keep using Netty 4.1.x in 1.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

Re: [PR] Test Netty 4.2.0.RC4 [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1794:
URL: https://github.com/apache/pekko/pull/1794#issuecomment-2719699031

   @pjfanning That will require flink to upgrade netty too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org