You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/05 09:38:21 UTC

[GitHub] [iotdb] THUMarkLau opened a new pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

THUMarkLau opened a new pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170


   see [IOTDB-2651](https://issues.apache.org/jira/browse/IOTDB-2651)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai merged pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
ericpai merged pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#issuecomment-1059739414


   
   [![Coverage Status](https://coveralls.io/builds/47100265/badge)](https://coveralls.io/builds/47100265)
   
   Coverage increased (+0.04%) to 67.734% when pulling **0ba2167bbd8728778b37b839cb4ee144b282c972 on THUMarkLau:IOTDB-2651** into **107cdc6d2f6a8a6417671b5ebcf92acbc907c95a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#issuecomment-1059739414


   
   [![Coverage Status](https://coveralls.io/builds/47155688/badge)](https://coveralls.io/builds/47155688)
   
   Coverage increased (+0.1%) to 67.824% when pulling **566bacf5c35a78fe5f8e4aefcbfffca5a23ca6cb on THUMarkLau:IOTDB-2651** into **107cdc6d2f6a8a6417671b5ebcf92acbc907c95a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#issuecomment-1059739414


   
   [![Coverage Status](https://coveralls.io/builds/47156483/badge)](https://coveralls.io/builds/47156483)
   
   Coverage increased (+0.1%) to 67.815% when pulling **566bacf5c35a78fe5f8e4aefcbfffca5a23ca6cb on THUMarkLau:IOTDB-2651** into **107cdc6d2f6a8a6417671b5ebcf92acbc907c95a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r820107005



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -238,7 +239,8 @@ public synchronized void submitTaskFromTaskQueue() {
     try {
       while (currentTaskNum.get()
               < IoTDBDescriptor.getInstance().getConfig().getConcurrentCompactionThread()
-          && !candidateCompactionTaskQueue.isEmpty()) {
+          && !candidateCompactionTaskQueue.isEmpty()
+          && candidateCompactionTaskQueue.toString() != null) {

Review comment:
       Why use `candidateCompactionTaskQueue.toString()` as a condition here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r821367954



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -88,10 +94,10 @@ public String toString() {
         .append(fullStorageGroupName)
         .append("-")
         .append(timePartition)
-        .append(" task seq file num is ")
-        .append(selectedSequenceFiles.size())
+        .append(" task seq file is ")

Review comment:
       resolve

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -88,10 +94,10 @@ public String toString() {
         .append(fullStorageGroupName)
         .append("-")
         .append(timePartition)
-        .append(" task seq file num is ")
-        .append(selectedSequenceFiles.size())
+        .append(" task seq file is ")
+        .append(selectedSequenceFiles.toString())
         .append(" , unseq file num is ")

Review comment:
       resolve




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r821367665



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -88,10 +94,10 @@ public String toString() {
         .append(fullStorageGroupName)
         .append("-")
         .append(timePartition)
-        .append(" task seq file num is ")
-        .append(selectedSequenceFiles.size())
+        .append(" task seq file is ")

Review comment:
       resolve




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#issuecomment-1059739414


   
   [![Coverage Status](https://coveralls.io/builds/47152130/badge)](https://coveralls.io/builds/47152130)
   
   Coverage increased (+0.1%) to 67.804% when pulling **3abdefff1d32460d9953ac4aa0506c67068114ed on THUMarkLau:IOTDB-2651** into **107cdc6d2f6a8a6417671b5ebcf92acbc907c95a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] ericpai commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r820673974



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -238,7 +239,8 @@ public synchronized void submitTaskFromTaskQueue() {
     try {
       while (currentTaskNum.get()
               < IoTDBDescriptor.getInstance().getConfig().getConcurrentCompactionThread()
-          && !candidateCompactionTaskQueue.isEmpty()) {
+          && !candidateCompactionTaskQueue.isEmpty()
+          && candidateCompactionTaskQueue.toString() != null) {

Review comment:
       Got it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r820667301



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -238,7 +239,8 @@ public synchronized void submitTaskFromTaskQueue() {
     try {
       while (currentTaskNum.get()
               < IoTDBDescriptor.getInstance().getConfig().getConcurrentCompactionThread()
-          && !candidateCompactionTaskQueue.isEmpty()) {
+          && !candidateCompactionTaskQueue.isEmpty()
+          && candidateCompactionTaskQueue.toString() != null) {

Review comment:
       This is a debug statement so that I can get  the return value of this statement through arthas. I will remove this statement later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on a change in pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#discussion_r821361756



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -88,10 +94,10 @@ public String toString() {
         .append(fullStorageGroupName)
         .append("-")
         .append(timePartition)
-        .append(" task seq file num is ")
-        .append(selectedSequenceFiles.size())
+        .append(" task seq file is ")
+        .append(selectedSequenceFiles.toString())
         .append(" , unseq file num is ")

Review comment:
       ```suggestion
           .append(" , unseq files are ")
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/AbstractCrossSpaceCompactionTask.java
##########
@@ -88,10 +94,10 @@ public String toString() {
         .append(fullStorageGroupName)
         .append("-")
         .append(timePartition)
-        .append(" task seq file num is ")
-        .append(selectedSequenceFiles.size())
+        .append(" task seq file is ")

Review comment:
       ```suggestion
           .append(" task seq files are ")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5170: [IOTDB-2651] Fix write performance deteriorates severely

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5170:
URL: https://github.com/apache/iotdb/pull/5170#issuecomment-1059739414


   
   [![Coverage Status](https://coveralls.io/builds/47100310/badge)](https://coveralls.io/builds/47100310)
   
   Coverage increased (+0.03%) to 67.724% when pulling **0ba2167bbd8728778b37b839cb4ee144b282c972 on THUMarkLau:IOTDB-2651** into **107cdc6d2f6a8a6417671b5ebcf92acbc907c95a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org