You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/05/23 02:29:26 UTC
[PR] Variable-hides-field hint optimization [netbeans]
mbien opened a new pull request, #8525:
URL: https://github.com/apache/netbeans/pull/8525
compilationinfo.getElements() in inner loop prevented the JVM from inlining calls into the loop body. Moving it out of the loop improves hint performance by 10x in files with many fields.
rest is cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Variable-hides-field hint optimization [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8525:
URL: https://github.com/apache/netbeans/pull/8525#issuecomment-2980373651
planning to merge this one soon since its one of the smaller ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Variable-hides-field hint optimization [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8525:
URL: https://github.com/apache/netbeans/pull/8525#discussion_r2103682448
##########
java/java.hints/src/org/netbeans/modules/java/hints/HideField.java:
##########
@@ -87,11 +88,12 @@ protected List<Fix> computeFixes(CompilationInfo compilationInfo, TreePath treeP
Element hidden = null;
TypeElement te = (TypeElement)el.getEnclosingElement();
+ Elements elements = compilationInfo.getElements();
for (Element field : getAllMembers(compilationInfo, te)) {
if (stop) {
return null;
}
- if (compilationInfo.getElements().hides(el, field)) {
+ if (elements.hides(el, field)) {
Review Comment:
that is the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Variable-hides-field hint optimization [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8525:
URL: https://github.com/apache/netbeans/pull/8525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists